Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(accessibility-testing): introduce cypress-axe-core #8233

Merged
merged 35 commits into from
Feb 21, 2022
Merged

feat(accessibility-testing): introduce cypress-axe-core #8233

merged 35 commits into from
Feb 21, 2022

Conversation

ariellalgilmore
Copy link
Member

@ariellalgilmore ariellalgilmore commented Feb 8, 2022 •
edited
Loading

Related Ticket(s)

#8063

Description

Add axe-core with cypress.

Changelog

New

  • added cypress command checkAxeA11y which calls checkA11y
    • has optional params context and additionalRules
  • added to each e2e-storybook test cy.injectAxe() and cy.checkAxeA11y()
  • added to plugins/index.js for us to use to be able to log as we test and use the table which is being used to print the validations
  • current setup is we are only checking critical issues and always returning true -> will change in the future as we resovle issues
  • added to card.e2e.js being able to focus on the card to show focus states
  • in footer.e2e.js showing how to use optional params in cy.checkAxeA11y()

@ariellalgilmore ariellalgilmore changed the title feat(cypress-axe-core): in web components feat(accessibility-testing): intruduce cypress-axe-core Feb 8, 2022
@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Feb 8, 2022 •
edited
Loading

Deploy preview created for package React:
https://ibmdotcom-react.s3.us-south.cloud-object-storage.appdomain.cloud/deploy-previews/8233/index.html

Built with commit: badbc88e83c2b1c5365dff058afdb38c4a324bfc

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Feb 8, 2022 •
edited
Loading

Deploy preview created for package Web Components (React wrapper):
https://ibmdotcom-web-components-react.s3-web.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/8233/index.html

Built with commit: badbc88e83c2b1c5365dff058afdb38c4a324bfc

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Feb 8, 2022 •
edited
Loading

Deploy preview created for package Web Components HTML Test Application:
https://ibmdotcom-web-components-html-test-upstream.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/8233/index.html

Built with commit: badbc88e83c2b1c5365dff058afdb38c4a324bfc

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Feb 8, 2022 •
edited
Loading

Deploy preview created for package Web Components:
https://ibmdotcom-webcomponents.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/8233/index.html

Built with commit: badbc88e83c2b1c5365dff058afdb38c4a324bfc

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Feb 8, 2022 •
edited
Loading

Deploy preview created for package NextJS Test Application:
https://ibmdotcom-nextjs-test-upstream.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/8233/index.html

Built with commit: badbc88e83c2b1c5365dff058afdb38c4a324bfc

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Feb 9, 2022 •
edited
Loading

Deploy preview created for package "Web Components (Codesandbox Examples)":
https://webcomponents-codesandbox.s3-web.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/8233/index.html

Built with commit: badbc88e83c2b1c5365dff058afdb38c4a324bfc

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Feb 9, 2022 •
edited
Loading

Deploy preview created for package "React (Codesandbox Examples)":
https://react-codesandbox.s3-web.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/8233/index.html

Built with commit: badbc88e83c2b1c5365dff058afdb38c4a324bfc

@ariellalgilmore ariellalgilmore added the test: e2e used for automated e2e testing label Feb 10, 2022
@ariellalgilmore ariellalgilmore marked this pull request as ready for review February 10, 2022 16:48
@ariellalgilmore ariellalgilmore requested a review from a team as a code owner February 10, 2022 16:48
@proeung proeung requested a review from andy-blum February 17, 2022 17:20
@andy-blum
Copy link
Contributor

The cloud-masthead e2e failures look like what I would expect if the tests are running without the experimental platform feature. @proeung Do you know how to enable that for a specific PR?

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Feb 17, 2022 •
edited
Loading

Deploy preview created for package "React (experimental)":
https://ibmdotcom-react-experimental.s3.us-south.cloud-object-storage.appdomain.cloud/deploy-previews/8233/index.html

Built with commit: badbc88e83c2b1c5365dff058afdb38c4a324bfc

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Feb 17, 2022 •
edited
Loading

Deploy preview created for package "Web Components (experimental)":
https://ibmdotcom-web-components-experimental.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/8233/index.html

Built with commit: badbc88e83c2b1c5365dff058afdb38c4a324bfc

@ariellalgilmore ariellalgilmore mentioned this pull request Feb 18, 2022
Merged
jeffchew
jeffchew approved these changes Feb 21, 2022
View reviewed changes
Copy link
Member

@jeffchew jeffchew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @ariellalgilmore !

@jeffchew jeffchew dismissed andy-blum’s stale review February 21, 2022 13:31

Looks like this was addressed.

@jeffchew jeffchew added the Ready to merge Label for the pull requests that are ready to merge label Feb 21, 2022
@kodiakhq kodiakhq bot merged commit 48fb0f5 into carbon-design-system:main Feb 21, 2022
@ariellalgilmore ariellalgilmore deleted the feat/axe-core-cypress-integration branch February 21, 2022 16:02
@emyarod emyarod mentioned this pull request Mar 2, 2022
Merged
kodiakhq bot pushed a commit that referenced this pull request Mar 9, 2022
@emyarod
chore: downgrade cypress (#8437)
8023120 
### Related Ticket(s)

#8233
#8147

### Description

This PR downgrades Cypress in the `web-components` package back to v8.1.0 due to out of memory issues present in v8.2+

Firefox is also added to the browsers matrix again for end to end tests

<!-- React and Web Component deploy previews are enabled by default. -->
<!-- To enable additional available deploy previews, apply the following -->
<!-- labels for the corresponding package: -->
<!-- *** "test: e2e": Codesandbox examples and e2e integration tests -->
<!-- *** "package: services": Services -->
<!-- *** "package: utilities": Utilities -->
<!-- *** "RTL": React / Web Components (RTL) -->
<!-- *** "feature flag": React / Web Components (experimental) -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@annawen1 annawen1 annawen1 left review comments

@andy-blum andy-blum andy-blum left review comments

@jeffchew jeffchew jeffchew approved these changes

@emyarod emyarod Awaiting requested review from emyarod emyarod is a code owner automatically assigned from carbon-design-system/carbon-for-ibm-com-members

Assignees
No one assigned
Labels
feature flag Ready to merge Label for the pull requests that are ready to merge test: e2e used for automated e2e testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ariellalgilmore @ibmdotcom-bot @jeffchew @andy-blum @annawen1