Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(e2e): mock ibm-common.js in e2e tests #8147

Merged
merged 30 commits into from
Jan 28, 2022
Merged

fix(e2e): mock ibm-common.js in e2e tests #8147

merged 30 commits into from
Jan 28, 2022

Conversation

jeffchew
Copy link
Member

Related Ticket(s)

Refs #7898

Description

The footer tests were still failing for the footer in Browserstack automate. This is an attempt to approach the fix in a different way, and instead to block the cookie preferences (ibm-common.js) from loading entirely.

This also introduces the approach for globally mocking network calls rather than doing it in a per-test approach.

Changelog

New

  • ibm-common.js fixture in e2e tests

Changed

  • moved cypress fixtures in global support index.js

@jeffchew jeffchew requested a review from a team as a code owner January 25, 2022 21:43
@jeffchew jeffchew mentioned this pull request Jan 25, 2022
Closed
2 tasks
@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Jan 25, 2022 •
edited
Loading

Deploy preview created for package React:
https://ibmdotcom-react.s3.us-south.cloud-object-storage.appdomain.cloud/deploy-previews/8147/index.html

Built with commit: c3d5615b5c87797153e2d66c32d6f005027ba782

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Jan 25, 2022 •
edited
Loading

Deploy preview created for package Web Components (React wrapper):
https://ibmdotcom-web-components-react.s3-web.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/8147/index.html

Built with commit: c3d5615b5c87797153e2d66c32d6f005027ba782

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Jan 25, 2022 •
edited
Loading

Deploy preview created for package Web Components HTML Test Application:
https://ibmdotcom-web-components-html-test-upstream.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/8147/index.html

Built with commit: c3d5615b5c87797153e2d66c32d6f005027ba782

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Jan 25, 2022 •
edited
Loading

Deploy preview created for package Web Components:
https://ibmdotcom-webcomponents.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/8147/index.html

Built with commit: c3d5615b5c87797153e2d66c32d6f005027ba782

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Jan 25, 2022 •
edited
Loading

Deploy preview created for package NextJS Test Application:
https://ibmdotcom-nextjs-test-upstream.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/8147/index.html

Built with commit: c3d5615b5c87797153e2d66c32d6f005027ba782

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Jan 26, 2022 •
edited
Loading

Deploy preview created for package "Web Components (Codesandbox Examples)":
https://webcomponents-codesandbox.s3-web.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/8147/index.html

Built with commit: c3d5615b5c87797153e2d66c32d6f005027ba782

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Jan 26, 2022 •
edited
Loading

Deploy preview created for package "React (Codesandbox Examples)":
https://react-codesandbox.s3-web.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/8147/index.html

Built with commit: c3d5615b5c87797153e2d66c32d6f005027ba782

@proeung proeung requested a review from andy-blum January 26, 2022 15:40
@jeffchew jeffchew mentioned this pull request Jan 27, 2022
Closed
emyarod
emyarod approved these changes Jan 28, 2022
View reviewed changes
Copy link
Member

@emyarod emyarod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, just one question about a disabled test

packages/react/tests/e2e-storybook/cypress/integration/CTA/Feature.e2e.js
@@ -172,7 +172,7 @@ describe('dds-feature-cta | (desktop)', () => {
});

it('Should load and be fully clickable', _tests.checkBlockLink);
it(
xit(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we add a note about this omitted test?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh just saw your note after the PR was merged. I'll open up a PR with a note.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually let me create an issue for this too.

@emyarod emyarod mentioned this pull request Jan 28, 2022
Closed
@jeffchew jeffchew added the Ready to merge Label for the pull requests that are ready to merge label Jan 28, 2022
@jeffchew jeffchew merged commit a32b3e5 into carbon-design-system:main Jan 28, 2022
@jeffchew jeffchew deleted the fix/cypress-ibm-common branch January 28, 2022 21:55
@andy-blum andy-blum removed their request for review January 31, 2022 21:01
@emyarod emyarod mentioned this pull request Mar 2, 2022
Merged
kodiakhq bot pushed a commit that referenced this pull request Mar 9, 2022
@emyarod
chore: downgrade cypress (#8437)
8023120 
### Related Ticket(s)

#8233
#8147

### Description

This PR downgrades Cypress in the `web-components` package back to v8.1.0 due to out of memory issues present in v8.2+

Firefox is also added to the browsers matrix again for end to end tests

<!-- React and Web Component deploy previews are enabled by default. -->
<!-- To enable additional available deploy previews, apply the following -->
<!-- labels for the corresponding package: -->
<!-- *** "test: e2e": Codesandbox examples and e2e integration tests -->
<!-- *** "package: services": Services -->
<!-- *** "package: utilities": Utilities -->
<!-- *** "RTL": React / Web Components (RTL) -->
<!-- *** "feature flag": React / Web Components (experimental) -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emyarod emyarod emyarod approved these changes

@oliviaflory oliviaflory Awaiting requested review from oliviaflory oliviaflory is a code owner automatically assigned from carbon-design-system/carbon-for-ibm-com-members

@annawen1 annawen1 Awaiting requested review from annawen1 annawen1 is a code owner automatically assigned from carbon-design-system/carbon-for-ibm-com-members

Assignees
No one assigned
Labels
Ready to merge Label for the pull requests that are ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jeffchew @ibmdotcom-bot @emyarod