Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: downgrade cypress #8437

Merged
merged 2 commits into from
Mar 9, 2022
Merged

chore: downgrade cypress #8437

merged 2 commits into from
Mar 9, 2022

Conversation

emyarod
Copy link
Member

@emyarod emyarod commented Mar 2, 2022 •
edited
Loading

Related Ticket(s)

#8233
#8147

Description

This PR downgrades Cypress in the web-components package back to v8.1.0 due to out of memory issues present in v8.2+

Firefox is also added to the browsers matrix again for end to end tests

@emyarod emyarod self-assigned this Mar 2, 2022
@emyarod emyarod force-pushed the downgrade-web-components-cypress branch from d14b89d to a2c2567 Compare March 2, 2022 18:32
@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Mar 2, 2022 •
edited
Loading

Deploy preview created for package React:
https://ibmdotcom-react.s3.us-south.cloud-object-storage.appdomain.cloud/deploy-previews/8437/index.html

Built with commit: b320a31b3d4397f015ba89ce2a7842ee6ca42c31

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Mar 2, 2022 •
edited
Loading

Deploy preview created for package NextJS Test Application:
https://ibmdotcom-nextjs-test-upstream.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/8437/index.html

Built with commit: b320a31b3d4397f015ba89ce2a7842ee6ca42c31

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Mar 2, 2022 •
edited
Loading

Deploy preview created for package Web Components HTML Test Application:
https://ibmdotcom-web-components-html-test-upstream.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/8437/index.html

Built with commit: b320a31b3d4397f015ba89ce2a7842ee6ca42c31

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Mar 2, 2022 •
edited
Loading

Deploy preview created for package Web Components:
https://ibmdotcom-webcomponents.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/8437/index.html

Built with commit: b320a31b3d4397f015ba89ce2a7842ee6ca42c31

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Mar 2, 2022 •
edited
Loading

Deploy preview created for package Web Components (React wrapper):
https://ibmdotcom-web-components-react.s3-web.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/8437/index.html

Built with commit: b320a31b3d4397f015ba89ce2a7842ee6ca42c31

@emyarod emyarod force-pushed the downgrade-web-components-cypress branch from 4e55be3 to a2c2567 Compare March 4, 2022 17:38
@emyarod emyarod force-pushed the downgrade-web-components-cypress branch from a2c2567 to 5dacdf6 Compare March 4, 2022 17:41
@emyarod emyarod marked this pull request as ready for review March 7, 2022 17:42
@emyarod emyarod requested a review from a team as a code owner March 7, 2022 17:42
kennylam
kennylam approved these changes Mar 8, 2022
View reviewed changes
Copy link
Member

@kennylam kennylam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @emyarod!

@kennylam kennylam added the Ready to merge Label for the pull requests that are ready to merge label Mar 8, 2022
@kodiakhq kodiakhq bot merged commit 8023120 into carbon-design-system:main Mar 9, 2022
@emyarod emyarod deleted the downgrade-web-components-cypress branch March 10, 2022 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kennylam kennylam kennylam approved these changes

@RichKummer RichKummer Awaiting requested review from RichKummer RichKummer is a code owner automatically assigned from carbon-design-system/carbon-for-ibm-com-members

@IgnacioBecerra IgnacioBecerra Awaiting requested review from IgnacioBecerra IgnacioBecerra is a code owner automatically assigned from carbon-design-system/carbon-for-ibm-com-members

Assignees

@emyarod emyarod

Labels
Ready to merge Label for the pull requests that are ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@emyarod @ibmdotcom-bot @kennylam