Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(storybook): exclude storybook e2e tests from browserstack #8333

Merged
merged 4 commits into from
Feb 21, 2022
Merged

test(storybook): exclude storybook e2e tests from browserstack #8333

merged 4 commits into from
Feb 21, 2022

Conversation

annawen1
Copy link
Member

Related Ticket(s)

{{Provide url(s) to the related ticket(s) that this pull request addresses}}

Description

Storybook Docs e2e tests don't need to be run on Browserstack, so add the files to the exclude field.

Also remove the no longer necessary if statement in the cloud-masthead test checking for the env variable.

@annawen1 annawen1 requested a review from a team as a code owner February 17, 2022 18:37
@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Feb 17, 2022 •
edited
Loading

Deploy preview created for package Web Components HTML Test Application:
https://ibmdotcom-web-components-html-test-upstream.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/8333/index.html

Built with commit: 8b6d6ae9c288f0c7979a984f3bddfc853445d2cf

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Feb 17, 2022 •
edited
Loading

Deploy preview created for package NextJS Test Application:
https://ibmdotcom-nextjs-test-upstream.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/8333/index.html

Built with commit: 8b6d6ae9c288f0c7979a984f3bddfc853445d2cf

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Feb 17, 2022 •
edited
Loading

Deploy preview created for package Web Components (React wrapper):
https://ibmdotcom-web-components-react.s3-web.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/8333/index.html

Built with commit: 8b6d6ae9c288f0c7979a984f3bddfc853445d2cf

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Feb 17, 2022 •
edited
Loading

Deploy preview created for package React:
https://ibmdotcom-react.s3.us-south.cloud-object-storage.appdomain.cloud/deploy-previews/8333/index.html

Built with commit: 8b6d6ae9c288f0c7979a984f3bddfc853445d2cf

ariellalgilmore
ariellalgilmore approved these changes Feb 17, 2022
View reviewed changes
Copy link
Member

@ariellalgilmore ariellalgilmore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ariellalgilmore ariellalgilmore self-requested a review February 17, 2022 21:00
@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Feb 17, 2022 •
edited
Loading

Deploy preview created for package Web Components:
https://ibmdotcom-webcomponents.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/8333/index.html

Built with commit: 8b6d6ae9c288f0c7979a984f3bddfc853445d2cf

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Feb 17, 2022 •
edited
Loading

Deploy preview created for package "Web Components (Codesandbox Examples)":
https://webcomponents-codesandbox.s3-web.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/8333/index.html

Built with commit: 8b6d6ae9c288f0c7979a984f3bddfc853445d2cf

@IgnacioBecerra
Copy link
Contributor

@annawen1 All of the e2e tests for the cloud masthead are failing... Could be that the component never loads?

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Feb 18, 2022 •
edited
Loading

Deploy preview created for package "React (Codesandbox Examples)":
https://react-codesandbox.s3-web.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/8333/index.html

Built with commit: 8b6d6ae9c288f0c7979a984f3bddfc853445d2cf

kennylam
kennylam approved these changes Feb 18, 2022
View reviewed changes
Copy link
Member

@kennylam kennylam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks @annawen1!

@ariellalgilmore
Copy link
Member

the cloud masthead issue will be fixed in this PR:#8233

@jeffchew
Copy link
Member

@annawen1 looks like there's merge conflicts now that #8233 is merged, can you take a look?

jeffchew
jeffchew approved these changes Feb 21, 2022
View reviewed changes
Copy link
Member

@jeffchew jeffchew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jeffchew jeffchew added the Ready to merge Label for the pull requests that are ready to merge label Feb 21, 2022
@jeffchew jeffchew merged commit 8b069ea into carbon-design-system:main Feb 21, 2022
@jeffchew jeffchew deleted the test/storybook-docs-e2e branch February 21, 2022 21:26
@IgnacioBecerra IgnacioBecerra mentioned this pull request Feb 25, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeffchew jeffchew jeffchew approved these changes

@kennylam kennylam kennylam approved these changes

@RichKummer RichKummer Awaiting requested review from RichKummer RichKummer is a code owner automatically assigned from carbon-design-system/carbon-for-ibm-com-members

@IgnacioBecerra IgnacioBecerra Awaiting requested review from IgnacioBecerra IgnacioBecerra is a code owner automatically assigned from carbon-design-system/carbon-for-ibm-com-members

@ariellalgilmore ariellalgilmore Awaiting requested review from ariellalgilmore

Assignees
No one assigned
Labels
Ready to merge Label for the pull requests that are ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@annawen1 @ibmdotcom-bot @IgnacioBecerra @ariellalgilmore @jeffchew @kennylam