Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The slots no longer work on radio buttons #11288

Closed
2 tasks done
abdonrd opened this issue Jan 2, 2024 · 5 comments · Fixed by #11307
Closed
2 tasks done

The slots no longer work on radio buttons #11288

abdonrd opened this issue Jan 2, 2024 · 5 comments · Fixed by #11307
Assignees
@ariellalgilmore
Labels
bug Something isn't working dev Needs some dev work

Comments

@abdonrd
Copy link
Contributor

abdonrd commented Jan 2, 2024 •
edited
Loading

Description

The slots no longer work on the radio buttons / checkbox:

✅ Application with @carbon/[email protected]:
https://stackblitz.com/edit/vitejs-vite-58y3ua?file=package.json

Screenshot 2024-01-02 at 3 00 56 PM

❌ Application with @carbon/[email protected]:
https://stackblitz.com/edit/vitejs-vite-txbijy?file=package.json

Screenshot 2024-01-02 at 3 01 10 PM

Component(s) impacted

Radio button & Checkbox

Browser

Chrome, Safari, Firefox, Microsoft Edge

Severity

Severity 1 = The design is broken in a critical way that blocks users from completing tasks or damages the brand. Affects major functionality, no workaround.

Application/website

IBM Quantum

Package

@carbon/web-components

Code of Conduct
@abdonrd abdonrd added bug Something isn't working dev Needs some dev work labels Jan 2, 2024
@abdonrd abdonrd changed the title The slots no longer work on the radio buttons / checkbox The slots no longer work on radio buttons / checkbox Jan 2, 2024
@abdonrd
Copy link
Contributor Author

abdonrd commented Jan 3, 2024

Probably related with these PRs?

@annawen1
Copy link
Member

annawen1 commented Jan 3, 2024 •
edited
Loading

@abdonrd double-checking, looks like the slots do work with checkbox

https://stackblitz.com/edit/vitejs-vite-ebrzif?file=index.html

Is there another issue with checkbox? In the meantime, we'll open a PR for radio-button

@m4olivei m4olivei mentioned this issue Jan 3, 2024
Merged
@ariellalgilmore ariellalgilmore mentioned this issue Jan 3, 2024
Merged
@abdonrd
Copy link
Contributor Author

abdonrd commented Jan 3, 2024

@annawen1 oh! I think you're right! Checkbox are working well.

@ariellalgilmore
Copy link
Member

ariellalgilmore commented Jan 3, 2024 •
edited
Loading

@abdonrd radio-button PR is in and will be part of the next release, since there is a work around using the label-text property

@abdonrd
Copy link
Contributor Author

abdonrd commented Jan 3, 2024

@abdonrd radio-button PR is in and will be part of the next release, since there is a work around using the label-text property

Thanks!

We can't use the label-text, because we have something like this:

Screenshot 2024-01-03 at 2 04 55 PM

@abdonrd abdonrd changed the title The slots no longer work on radio buttons / checkbox The slots no longer work on radio buttons Jan 4, 2024
@kodiakhq kodiakhq bot closed this as completed in #11307 Jan 4, 2024
kodiakhq bot pushed a commit that referenced this issue Jan 4, 2024
@ariellalgilmore
fix(radio-button): add missing slot optioin (#11307)
95e9eb5 
### Related Ticket(s)

Closes #11288 
### Description

fixes slot for radio-button
### Changelog

**New**

- {{new thing}}

**Changed**

- accidentally got removed .... but adding `<slot>` around `${labelText}`

**Removed**

- {{removed thing}}

<!-- React and Web Component deploy previews are enabled by default. -->
<!-- To enable additional available deploy previews, apply the following -->
<!-- labels for the corresponding package: -->
<!-- *** "test: e2e": Codesandbox examples and e2e integration tests -->
<!-- *** "package: services": Services -->
<!-- *** "package: utilities": Utilities -->
<!-- *** "RTL": React / Web Components (RTL) -->
<!-- *** "feature flag": React / Web Components (experimental) -->
@github-project-automation github-project-automation bot moved this from Review to Done in Carbon for IBM.com Jan 4, 2024
kennylam pushed a commit to kennylam/carbon-for-ibm-dotcom that referenced this issue Mar 12, 2024
@ariellalgilmore @kennylam
fix(radio-button): add missing slot optioin (carbon-design-system#11307)
b1d79ab 
### Related Ticket(s)

Closes carbon-design-system#11288 
### Description

fixes slot for radio-button
### Changelog

**New**

- {{new thing}}

**Changed**

- accidentally got removed .... but adding `<slot>` around `${labelText}`

**Removed**

- {{removed thing}}

<!-- React and Web Component deploy previews are enabled by default. -->
<!-- To enable additional available deploy previews, apply the following -->
<!-- labels for the corresponding package: -->
<!-- *** "test: e2e": Codesandbox examples and e2e integration tests -->
<!-- *** "package: services": Services -->
<!-- *** "package: utilities": Utilities -->
<!-- *** "RTL": React / Web Components (RTL) -->
<!-- *** "feature flag": React / Web Components (experimental) -->
kennylam pushed a commit to kennylam/carbon-for-ibm-dotcom that referenced this issue Jun 11, 2024
@ariellalgilmore
fix(radio-button): add missing slot optioin (carbon-design-system#11307)
2315892 
### Related Ticket(s)

Closes carbon-design-system#11288 
### Description

fixes slot for radio-button
### Changelog

**New**

- {{new thing}}

**Changed**

- accidentally got removed .... but adding `<slot>` around `${labelText}`

**Removed**

- {{removed thing}}

<!-- React and Web Component deploy previews are enabled by default. -->
<!-- To enable additional available deploy previews, apply the following -->
<!-- labels for the corresponding package: -->
<!-- *** "test: e2e": Codesandbox examples and e2e integration tests -->
<!-- *** "package: services": Services -->
<!-- *** "package: utilities": Utilities -->
<!-- *** "RTL": React / Web Components (RTL) -->
<!-- *** "feature flag": React / Web Components (experimental) -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ariellalgilmore ariellalgilmore

Labels
bug Something isn't working dev Needs some dev work
Projects
Carbon for IBM.com
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(radio-button): add missing slot optioin ariellalgilmore/carbon-for-ibm-dotcom
3 participants
@abdonrd @ariellalgilmore @annawen1