feat(accordion): update story to Storybook v7 #11306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m4olivei
requested review from
IgnacioBecerra and
sangeethababu9223
and removed request for
a team
|
Deploy preview created for package Built with commit: 45f08b03c0367bfcdd576171b77d7a21cfa1afa2 |
|
Hey @kennylam 👋 . Looks like your latest commit was unrelated to |
|
Hm, no I was just fixing this failing ci-check which was failing because of some simple format issues. |
|
Ahh! Nevermind then. Thanks 😊 |
kennylam
reviewed
Jan 3, 2024
packages/carbon-web-components/src/components/accordion/accordion.stories.ts
Outdated
Show resolved
Hide resolved
kennylam
approved these changes
Jan 3, 2024
m4olivei
force-pushed
the
chore/accordion-sb-v7
branch
from
667df0e to
6826654
Compare
IgnacioBecerra
approved these changes
Jan 10, 2024
IgnacioBecerra
merged commit c4772f9
into
carbon-design-system:feat/cwc-storybook-7-vite
2 of 10 checks passed
kennylam
pushed a commit
to kennylam/carbon-for-ibm-dotcom
that referenced
this pull request
Jun 11, 2024
…1306) * chore(accordion): first pass at updating accordion for sb v7 * chore(accordion): finish updating accordion to sb v7 * chore(accordion): tidy up excess import --------- Co-authored-by: Ignacio Becerra <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Ticket(s)
Closes #11298
Description
Adjustments to accordion component to be compatible with Storybook v7.
Changelog
Changed