Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(radio-button): slug #11208

Conversation

ariellalgilmore
Copy link
Member

@ariellalgilmore ariellalgilmore commented Dec 7, 2023

Related Ticket(s)

Closes #11141

Description

Adds slug slot to radio-button and radio-button-group

Changelog

New

  • slug option to radio-button and radio-button-group
  • radio-button slug changes size depending on slug kind

Changed

  • changing the id and query logic allowed the modal to appear from the slug
  • fix error in radio-button invalid where the checked radio-button border wasn't turning red
  • cleaned up slug-story.scss to use tokens

Testing

Experimental -> Slug -> Examples -> Radio Button

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Dec 7, 2023

Deploy preview created for package Carbon Web Components:
https://carbon-web-components.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/11208/index.html

Built with commit: 9f1a53183b37b0969e1eb9667821989aa3019376

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Dec 7, 2023

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Dec 7, 2023

@ariellalgilmore ariellalgilmore added package: carbon web components area: AI Used to filter issues in the Carbon for AI project. labels Dec 8, 2023
@ariellalgilmore ariellalgilmore marked this pull request as ready for review December 8, 2023 17:13
@ariellalgilmore ariellalgilmore requested a review from a team as a code owner December 8, 2023 17:13
Copy link
Member

@aagonzales aagonzales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍 ✅

@ariellalgilmore ariellalgilmore merged commit 5b48b8f into carbon-design-system:main Dec 8, 2023
11 of 20 checks passed
@ariellalgilmore ariellalgilmore deleted the feat/radio-butotn-slug branch December 8, 2023 19:19
kennylam pushed a commit to kennylam/carbon-for-ibm-dotcom that referenced this pull request Jun 11, 2024
* feat(radio-button): slug

* fix(radion-button): opening slug and cleanup

* fix(tile): style token
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: AI Used to filter issues in the Carbon for AI project. package: carbon web components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CWC Radio Button] Add AI enhancements
4 participants