Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(checkbox): slug #11215

Merged

Conversation

annawen1
Copy link
Member

@annawen1 annawen1 commented Dec 11, 2023

Related Ticket(s)

Closes #11140

Description

Adds slug slot to checkbox and new component - checkbox-group

Changelog

New

  • cds-checkbox-group component
  • new states for cds-checkbox component - warn and invalid to sync with core Carbon
  • new story for checkbox (Single) to display the warn and invalid states of checkbox
  • slug option to checkbox and checkbox-group

Testing

Experimental -> Slug -> Examples -> Checkbox

@annawen1 annawen1 requested a review from a team as a code owner December 11, 2023 19:11
@annawen1 annawen1 requested a review from aagonzales December 11, 2023 20:55
@kennylam kennylam closed this Dec 12, 2023
@kennylam kennylam reopened this Dec 12, 2023
@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Dec 12, 2023

Deploy preview created for package Carbon Web Components:
https://carbon-web-components.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/11215/index.html

Built with commit: 94e01daeebc870e624c3766ec1369b343e408146

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Dec 12, 2023

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Dec 12, 2023

@ariellalgilmore ariellalgilmore changed the base branch from main to release-cwc/v2.1.0 December 12, 2023 16:45
Copy link
Member

@aagonzales aagonzales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! ✅ 👍

Copy link
Member

@ariellalgilmore ariellalgilmore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@annawen1 annawen1 added package: carbon web components area: AI Used to filter issues in the Carbon for AI project. labels Dec 13, 2023
@annawen1 annawen1 merged commit 279da1f into carbon-design-system:release-cwc/v2.1.0 Dec 14, 2023
5 of 8 checks passed
@annawen1 annawen1 deleted the feat/checkbox-slug branch December 14, 2023 14:20
kennylam pushed a commit to kennylam/carbon-for-ibm-dotcom that referenced this pull request Jun 11, 2024
* feat(checkbox): checkbox group component and new checkbox states

* feat(checkbox): checkbox group

* feat(checkbox): add slug to checkbox

* feat(checkbox): add slug outside of label

* feat(checkbox): add styling for invalid state in group

* feat(checkbox): set only border color

---------

Co-authored-by: Ariella Gilmore <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: AI Used to filter issues in the Carbon for AI project. package: carbon web components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CWC Checkbox] Add AI enhancements
5 participants