-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(checkbox): slug #11215
feat(checkbox): slug #11215
Conversation
Deploy preview created for package Built with commit: 94e01daeebc870e624c3766ec1369b343e408146 |
Deploy preview created for package Built with commit: 94e01daeebc870e624c3766ec1369b343e408146 |
Deploy preview created for package Built with commit: 94e01daeebc870e624c3766ec1369b343e408146 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! ✅ 👍
packages/carbon-web-components/src/components/checkbox/checkbox.scss
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
279da1f
into
carbon-design-system:release-cwc/v2.1.0
* feat(checkbox): checkbox group component and new checkbox states * feat(checkbox): checkbox group * feat(checkbox): add slug to checkbox * feat(checkbox): add slug outside of label * feat(checkbox): add styling for invalid state in group * feat(checkbox): set only border color --------- Co-authored-by: Ariella Gilmore <[email protected]>
Related Ticket(s)
Closes #11140
Description
Adds slug slot to checkbox and new component - checkbox-group
Changelog
New
cds-checkbox-group
componentcds-checkbox
component -warn
andinvalid
to sync with core CarbonSingle
) to display thewarn
andinvalid
states of checkboxTesting
Experimental -> Slug -> Examples -> Checkbox