Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge 7.5 hotfixes #4458

Merged
merged 9 commits into from
Nov 30, 2023
Merged

Merge 7.5 hotfixes #4458

merged 9 commits into from
Nov 30, 2023

Conversation

sergiusens
Copy link
Collaborator

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • Have you successfully run make lint?
  • Have you successfully run pytest tests/unit?

mr-cal and others added 8 commits October 5, 2023 09:42
Signed-off-by: Callahan Kovacs <[email protected]>
Adds spread tests for `base: devel` spread tests and fixes multipass
spread tests.
Allows headless systems to fallback to a file based keyring backend.

Signed-off-by: Sergio Schvezov <[email protected]>
@codecov-commenter
Copy link

codecov-commenter commented Nov 29, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5ad3824) 89.18% compared to head (400e40b) 89.18%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4458   +/-   ##
=======================================
  Coverage   89.18%   89.18%           
=======================================
  Files         321      321           
  Lines       21655    21665   +10     
=======================================
+ Hits        19313    19322    +9     
- Misses       2342     2343    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sergiusens sergiusens force-pushed the hotfix/7.5-merge branch 2 times, most recently from 78cb9af to f2d6bee Compare November 29, 2023 13:45
Copy link
Contributor

@cmatsuoka cmatsuoka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@sergiusens sergiusens merged commit e1a671a into main Nov 30, 2023
11 of 12 checks passed
@sergiusens sergiusens deleted the hotfix/7.5-merge branch November 30, 2023 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants