Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): bump craft-providers to 1.19.1 #4421

Merged
merged 1 commit into from
Oct 30, 2023

Conversation

syu-w
Copy link
Contributor

@syu-w syu-w commented Oct 24, 2023

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • Have you successfully run make lint?
  • Have you successfully run pytest tests/unit?

Also included devel base tests.
And a fix to run tests in multipass.

Fixes: #4412
CRAFT-2171

@syu-w syu-w force-pushed the work/dep-craft-providers branch 3 times, most recently from f0a0560 to 102e07b Compare October 24, 2023 15:56
@codecov-commenter
Copy link

codecov-commenter commented Oct 24, 2023

Codecov Report

Merging #4421 (7185ef0) into hotfix/7.5 (0054b0c) will increase coverage by 0.00%.
The diff coverage is 81.81%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@             Coverage Diff             @@
##           hotfix/7.5    #4421   +/-   ##
===========================================
  Coverage       94.87%   94.88%           
===========================================
  Files             658      658           
  Lines           55144    55185   +41     
===========================================
+ Hits            52320    52361   +41     
  Misses           2824     2824           
Files Coverage Δ
snapcraft/commands/lint.py 100.00% <100.00%> (ø)
snapcraft/providers.py 97.75% <100.00%> (+0.02%) ⬆️
tests/unit/parts/test_lifecycle.py 100.00% <100.00%> (ø)
tests/unit/test_providers.py 100.00% <100.00%> (ø)
tests/unit/conftest.py 89.36% <66.66%> (-0.75%) ⬇️

... and 18 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@syu-w syu-w force-pushed the work/dep-craft-providers branch 3 times, most recently from ef50632 to 79136aa Compare October 24, 2023 20:19
@sergiusens sergiusens changed the title build(deps): bump craft-providers to 1.18.0 build(deps): bump craft-providers to 1.19.0 Oct 24, 2023
@syu-w syu-w force-pushed the work/dep-craft-providers branch 10 times, most recently from 2812f46 to bff08f3 Compare October 26, 2023 21:03
@syu-w syu-w changed the title build(deps): bump craft-providers to 1.19.0 build(deps): bump craft-providers to 1.19.1 Oct 26, 2023
@syu-w syu-w force-pushed the work/dep-craft-providers branch 2 times, most recently from 63053de to 859863a Compare October 26, 2023 22:51
Copy link
Collaborator

@mr-cal mr-cal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Also included devel base tests.
And a fix to run tests in multipass.
@mr-cal
Copy link
Collaborator

mr-cal commented Oct 30, 2023

Store spread test failure is unrelated (#4411)
Core18 spread test failure is unrelated (flutter/flutter#133881)

@mr-cal
Copy link
Collaborator

mr-cal commented Oct 30, 2023

Also fixes CRAFT-2174 via canonical/craft-providers#429

@mr-cal mr-cal merged commit caa3c9c into hotfix/7.5 Oct 30, 2023
12 of 14 checks passed
syu-w added a commit that referenced this pull request Oct 30, 2023
Adds spread tests for `base: devel` spread tests and fixes multipass
spread tests.
syu-w added a commit that referenced this pull request Oct 30, 2023
Adds spread tests for `base: devel` spread tests and fixes multipass
spread tests.
mr-cal pushed a commit that referenced this pull request Oct 31, 2023
Adds spread tests for `base: devel` spread tests and fixes multipass
spread tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants