Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: pin pyright #4420

Merged
merged 1 commit into from
Oct 23, 2023
Merged

ci: pin pyright #4420

merged 1 commit into from
Oct 23, 2023

Conversation

mr-cal
Copy link
Collaborator

@mr-cal mr-cal commented Oct 23, 2023

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • Have you successfully run make lint?
  • Have you successfully run pytest tests/unit?

On hotfix branches, pyright should be pinned like all other requirements.

@mr-cal mr-cal mentioned this pull request Oct 23, 2023
Merged
4 tasks
@mr-cal
ci: pin pyright
f1c8791 
Signed-off-by: Callahan Kovacs <[email protected]>
@mr-cal
Copy link
Collaborator Author

mr-cal commented Oct 23, 2023 •
edited
Loading

core18 spread test failure unrelated (upstream: flutter/flutter#133881)
store tests failures appear to be a connectivity issue

@mr-cal mr-cal requested a review from a team October 23, 2023 17:59
@lengau lengau requested a review from a team October 23, 2023 21:13
@mr-cal mr-cal merged commit 7cd7cba into hotfix/7.5 Oct 23, 2023
12 of 14 checks passed
@mr-cal mr-cal deleted the pin-pyright branch October 23, 2023 22:26
syu-w pushed a commit that referenced this pull request Jan 29, 2024
@mr-cal @syu-w
ci: pin pyright (#4420)
f278e75 
Signed-off-by: Callahan Kovacs <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lengau lengau lengau approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mr-cal @lengau