Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(project): improve error message for unsupported architectures #4392

Merged
merged 2 commits into from
Oct 5, 2023

Conversation

mr-cal
Copy link
Collaborator

@mr-cal mr-cal commented Oct 4, 2023

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • Have you successfully run make lint?
  • Have you successfully run pytest tests/unit?

Fixes #4214
(CRAFT-1808)

@mr-cal mr-cal changed the base branch from main to hotfix/7.5 October 5, 2023 00:11
@codecov-commenter
Copy link

codecov-commenter commented Oct 5, 2023

Codecov Report

Merging #4392 (bd0729c) into hotfix/7.5 (061b4f0) will decrease coverage by 0.01%.
The diff coverage is 91.66%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@              Coverage Diff               @@
##           hotfix/7.5    #4392      +/-   ##
==============================================
- Coverage       94.88%   94.88%   -0.01%     
==============================================
  Files             658      658              
  Lines           55138    55162      +24     
==============================================
+ Hits            52319    52341      +22     
- Misses           2819     2821       +2     
Files Coverage Δ
snapcraft/projects.py 96.38% <100.00%> (+0.04%) ⬆️
snapcraft/utils.py 91.75% <100.00%> (+0.18%) ⬆️
tests/unit/parts/test_lifecycle.py 100.00% <ø> (ø)
tests/unit/test_projects.py 100.00% <100.00%> (ø)
tests/unit/test_utils.py 98.99% <75.00%> (-1.01%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@mr-cal
Copy link
Collaborator Author

mr-cal commented Oct 5, 2023

Spread test failures are unrelated

@mr-cal mr-cal requested review from cmatsuoka and syu-w October 5, 2023 12:33
Copy link
Contributor

@tigarmo tigarmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@mr-cal mr-cal enabled auto-merge (squash) October 5, 2023 14:41
@mr-cal mr-cal disabled auto-merge October 5, 2023 14:41
@mr-cal mr-cal merged commit 0330bc3 into hotfix/7.5 Oct 5, 2023
10 of 12 checks passed
@mr-cal mr-cal deleted the validate-supported-architectures branch October 5, 2023 14:42
syu-w pushed a commit that referenced this pull request Jan 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

snapcraft 7.4.3 doesn't adequately complain about non-existent architectures
4 participants