feat!: validate devel bases #302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 9, 2024
tigarmo
reviewed
Apr 9, 2024
Signed-off-by: Callahan Kovacs <[email protected]>
Signed-off-by: Callahan Kovacs <[email protected]>
mr-cal
force-pushed
the
work/CRAFT-2675-base-validation
branch
from
744ebf4 to
da273cb
Compare
Signed-off-by: Callahan Kovacs <[email protected]>
lengau
requested changes
Apr 12, 2024
Signed-off-by: Callahan Kovacs <[email protected]>
- allow multiple OSs to register devel bases - raise an exception if the base alias cannot be decoded Signed-off-by: Callahan Kovacs <[email protected]>
Signed-off-by: Callahan Kovacs <[email protected]>
Signed-off-by: Callahan Kovacs <[email protected]>
Signed-off-by: Callahan Kovacs <[email protected]>
tigarmo
requested changes
Apr 18, 2024
- make error message more generic - move warning message to Project Signed-off-by: Callahan Kovacs <[email protected]>
3 tasks
mr-cal
added a commit
that referenced
this pull request
Apr 24, 2024
This is a partial revert of 'aeae554 feat!: validate devel bases (#302)'. The base validation is not reverted, but there is now a default implementation for `Project._providers_base()` such that applications do not need to subclass the Project model. Signed-off-by: Callahan Kovacs <[email protected]>
3 tasks
mr-cal
added a commit
that referenced
this pull request
Apr 24, 2024
This is a partial revert of 'aeae554 feat!: validate devel bases (#302)'. The base validation is not reverted, but there is now a default implementation for `Project._providers_base()` such that applications do not need to subclass the Project model. Signed-off-by: Callahan Kovacs <[email protected]>
mr-cal
added a commit
that referenced
this pull request
Apr 25, 2024
This is a partial revert of 'aeae554 feat!: validate devel bases (#302)'. The base validation is not reverted, but there is now a default implementation for `Project._providers_base()` such that applications do not need to subclass the Project model. Signed-off-by: Callahan Kovacs <[email protected]>
lengau
pushed a commit
that referenced
this pull request
Apr 26, 2024
This is a partial revert of 'aeae554 feat!: validate devel bases (#302)'. The base validation is not reverted, but there is now a default implementation for `Project._providers_base()` such that applications do not need to subclass the Project model. Signed-off-by: Callahan Kovacs <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tox?Upstream
build-basedevelvalidation for all *craft applications. This draft treatsdevelas the devel base, but I will update this to26.04 before this PR can land24.10 when it is available.Downstream integrations:
Fixes #298
(CRAFT-2675)