Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: validate devel bases with craft-application #532

Closed
wants to merge 11 commits into from

Conversation

mr-cal
Copy link
Collaborator

@mr-cal mr-cal commented Apr 9, 2024

@mr-cal mr-cal marked this pull request as draft April 9, 2024 18:27
rockcraft/models/project.py Outdated Show resolved Hide resolved
mr-cal and others added 5 commits April 11, 2024 09:50
@mr-cal mr-cal changed the title [DRAFT] feat: validate devel bases with craft-application feat: validate devel bases with craft-application Apr 12, 2024
@mr-cal mr-cal marked this pull request as ready for review April 12, 2024 13:50
@mr-cal mr-cal requested a review from tigarmo April 17, 2024 19:26
mr-cal added 2 commits April 18, 2024 13:07
@mr-cal
Copy link
Collaborator Author

mr-cal commented Apr 18, 2024

This PR will need to land after the next craft-application release.

I'm leaving this open and marked as a DRAFT to prevent accidental merges.

@mr-cal mr-cal marked this pull request as draft April 18, 2024 19:36
@tigarmo tigarmo requested a review from lengau April 18, 2024 20:12
mr-cal added a commit that referenced this pull request May 10, 2024
cherry-pick of #532

Signed-off-by: Callahan Kovacs <[email protected]>
@mr-cal
Copy link
Collaborator Author

mr-cal commented May 16, 2024

Completed via #569

@mr-cal mr-cal closed this May 16, 2024
@mr-cal mr-cal deleted the work/CRAFT-2675-base-validation branch May 16, 2024 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants