-
Notifications
You must be signed in to change notification settings - Fork 455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: validate devel bases with craft-application #4721
Conversation
Signed-off-by: Callahan Kovacs <[email protected]>
Signed-off-by: Callahan Kovacs <[email protected]>
Signed-off-by: Callahan Kovacs <[email protected]>
f2f89e1
to
fb890a7
Compare
Signed-off-by: Callahan Kovacs <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4721 +/- ##
==========================================
+ Coverage 89.54% 89.57% +0.03%
==========================================
Files 337 331 -6
Lines 22638 22063 -575
==========================================
- Hits 20271 19763 -508
+ Misses 2367 2300 -67 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Callahan Kovacs <[email protected]>
Signed-off-by: Callahan Kovacs <[email protected]>
This PR will need to land after the next craft-application release. I'm leaving this open and marked as a DRAFT to prevent accidental merges. |
Signed-off-by: Callahan Kovacs <[email protected]>
Closing in favor of #4796 |
tox run -m lint
?tox run -e test-py310
? (supported versions:py39
,py310
,py311
,py312
)For canonical/craft-application#302 and canonical/craft-application#298
This has the side-effect that
build-base: devel
is no longer required forcore24
snaps.