Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: validate devel bases with craft-application #4721

Closed
wants to merge 8 commits into from

Conversation

mr-cal
Copy link
Collaborator

@mr-cal mr-cal commented Apr 9, 2024

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • Have you successfully run tox run -m lint?
  • Have you successfully run tox run -e test-py310? (supported versions: py39, py310, py311, py312)

For canonical/craft-application#302 and canonical/craft-application#298

This has the side-effect that build-base: devel is no longer required for core24 snaps.

@mr-cal mr-cal changed the title feat: validate devel bases with craft-application [DRAFT] feat: validate devel bases with craft-application Apr 9, 2024
@mr-cal mr-cal force-pushed the work/CRAFT-2675-base-validation branch from f2f89e1 to fb890a7 Compare April 11, 2024 15:26
@mr-cal mr-cal changed the title [DRAFT] feat: validate devel bases with craft-application feat: validate devel bases with craft-application Apr 12, 2024
Copy link

codecov bot commented Apr 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.57%. Comparing base (6ff73a1) to head (bb6399d).
Report is 18 commits behind head on main.

❗ Current head bb6399d differs from pull request most recent head ede6917. Consider uploading reports for the commit ede6917 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4721      +/-   ##
==========================================
+ Coverage   89.54%   89.57%   +0.03%     
==========================================
  Files         337      331       -6     
  Lines       22638    22063     -575     
==========================================
- Hits        20271    19763     -508     
+ Misses       2367     2300      -67     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

mr-cal added 2 commits April 17, 2024 15:18
Signed-off-by: Callahan Kovacs <[email protected]>
Signed-off-by: Callahan Kovacs <[email protected]>
@mr-cal
Copy link
Collaborator Author

mr-cal commented Apr 18, 2024

This PR will need to land after the next craft-application release.

I'm leaving this open and marked as a DRAFT to prevent accidental merges.

@mr-cal mr-cal marked this pull request as draft April 18, 2024 19:35
@mr-cal
Copy link
Collaborator Author

mr-cal commented May 8, 2024

Closing in favor of #4796

@mr-cal mr-cal closed this May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant