revert: abstract Project class and _providers_base()
#322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
mr-cal
force-pushed
the
work/CRAFT-2824-revert-abstract-project
branch
from
35478bc to
9561a30
Compare
This is a partial revert of 'aeae554 feat!: validate devel bases (#302)'. The base validation is not reverted, but there is now a default implementation for `Project._providers_base()` such that applications do not need to subclass the Project model. Signed-off-by: Callahan Kovacs <[email protected]>
mr-cal
force-pushed
the
work/CRAFT-2824-revert-abstract-project
branch
from
9561a30 to
9932817
Compare
tigarmo
approved these changes
Apr 25, 2024
lengau
approved these changes
Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tox?This is a partial revert of 'aeae554 feat!: validate devel bases (#302)'.
The base validation from #302 has not been reverted, but there is now a default implementation for
Project._providers_base()such that applications do not need to subclass the Project model.The default naming convention for bases is
name@channel. Examples:[email protected]ubuntu@develalmalinux@9Charmcraft is the only public application that can use this default
_providers_base().A default BuildPlanner will come in a subsequent PR.
(CRAFT-2824)