Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate to BETA 100% #326

Merged
merged 1 commit into from
Aug 11, 2022
Merged

Conversation

atuchin-m
Copy link
Collaborator

Resolves brave/brave-browser#24471

PR to main: #325

Main issue: brave/brave-browser#23538

@atuchin-m atuchin-m requested a review from a team as a code owner August 5, 2022 15:04
@atuchin-m atuchin-m self-assigned this Aug 5, 2022
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into production approved after deliberating with @brave/uplift-approvers. QA has verified the PR on Nightly as per #309 (comment).

@kjozwiak kjozwiak merged commit 217fbe2 into production Aug 11, 2022
@bsclifton bsclifton deleted the enable-translate-in-beta-production branch August 12, 2022 08:05
@bsclifton
Copy link
Member

Quick heads up - this accidentally set the wrong value. The PR to main (#325) did set the correct value

We can keep this change though- as it closes out brave/brave-browser#24546

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants