Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set WebUI-based Rewards panel flag to Enabled by default (1.43.x) Beta #24546

Closed
Miyayes opened this issue Aug 9, 2022 · 4 comments
Closed

Comments

@Miyayes
Copy link
Collaborator

Miyayes commented Aug 9, 2022

Description

Same as #24062, except specify Beta, now that 1.43 is Beta.

Example PR: See here for the previous PR for 1.43.x Nightly: https://github.com/brave/brave-variations/pull/316/files

@diracdeltas
Copy link
Member

does this warrant a sec review? i don't think we've looked at this at any point, but maybe there's no risks here. my main concern would be rule of 2 violations like the ones that used to exist in wallet webui: https://chromium.googlesource.com/chromium/src/+/master/docs/security/rule-of-2.md

@kjozwiak
Copy link
Member

does this warrant a sec review? i don't think we've looked at this at any point, but maybe there's no risks here. my main concern would be rule of 2 violations like the ones that used to exist in wallet webui: https://chromium.googlesource.com/chromium/src/+/master/docs/security/rule-of-2.md

@diracdeltas this was already enabled on master using Griffen via brave/brave-variations#317 and QA'd via brave/brave-variations#316 (comment). The above is scheduled to be released via 1.43.x. We're planning on enabling the WebUI rewards panel on BETA using Griffin (same method as we did on master) so it can get some bake time on BETA before it's released via 1.43.x.

Should we wait till the above gets a security review? Or can we enable it on BETA so it can bake and only push to Production once the security team has done a review. Let me know if that works or if we should just wait before enabling on BETA.

@kjozwiak
Copy link
Member

Quick update: As per the conversation via Slack, we'll be pushing the above into BETA via Girffin either today/tomorrow.

@bsclifton
Copy link
Member

Unintentionally resolved with brave/brave-variations#326 (production)

I merged the change to staging with brave/brave-variations#328

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants