Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate to BETA 100% #325

Merged
merged 1 commit into from
Aug 5, 2022
Merged

Translate to BETA 100% #325

merged 1 commit into from
Aug 5, 2022

Conversation

atuchin-m
Copy link
Collaborator

@atuchin-m atuchin-m commented Aug 5, 2022

@atuchin-m atuchin-m requested a review from a team as a code owner August 5, 2022 15:02
@atuchin-m atuchin-m self-assigned this Aug 5, 2022
@atuchin-m atuchin-m mentioned this pull request Aug 5, 2022
@atuchin-m atuchin-m merged commit 95d52ab into main Aug 5, 2022
@kjozwiak kjozwiak deleted the enable-translate-in-beta branch August 11, 2022 02:09
@kjozwiak
Copy link
Member

kjozwiak commented Aug 11, 2022

Used the same approach used via #309 (comment) to ensure that the above change is working as expected.

Verification PASSED on Win 11 x64 using the following build(s):

Brave | 1.43.65 Chromium: 104.0.5112.81 (Official Build) beta (64-bit)
-- | --
Revision | 5b7b76419d50f583022568b6764b630f6ddc9208-refs/branch-heads/5112@{#1309}
OS | Windows 11 Version 21H2 (Build 22000.832)

BETA channel

Clean Profile via BETA

  • launched 1.43.65 Chromium: 104.0.5112.81 using the following:
    • brave.exe --enable-logging=stderr --variations-server-url=https://variations.bravesoftware.com/seed
  • once launched, restarted the browser again and ensured that BraveTranslateStudy:Enabled via brave://version
  • visited several websites using Polish, German & Spanish and ensured that the new UI appears via the URL bar
  • ensured that translating pages contacts the https://translate.brave.com endpoint
  • ensured that you can go back and forth between English and the language that's present on the page without issues
  • ensured that Always translate [x] works as expected
    • also ensured that disabling Always Translate [x] after it was enabled works as expected

image

Polish website being translated

Example Example Example
image image image

Japanese website being translated

Example Example Example
image image image

As mentioned above, also ensured that we're using https://translate.brave.com when translating pages as per the following:

Page automatically being translated Manually translating a page
image image

Profile with the Google Translate extension already installed

Before running through these cases, ensured that Google Translate was installed before re-launching the browser and being added into the BraveTranslateStudy:Enabled study.

  • ensured that our new Brave Translate UI doesn't appear via the URL bar when the Google Translate extension is installed
  • ensured that our new Brave Translate UI appears via the URL bar once the Google Translate extension was removed
    • also ensured that translations worked as expected once Brave switched to https://translate.brave.com from the extension
Aktuelle.Nachrichten._.BILD.de.-.Brave.2022-08-10.22-29-50.mp4

RELEASE channel

Verification PASSED on Win 11 x64 using the following build(s):

Brave | 1.42.88 Chromium: 104.0.5112.81 (Official Build) (64-bit)
-- | --
Revision | 5b7b76419d50f583022568b6764b630f6ddc9208-refs/branch-heads/5112@{#1309}
OS | Windows 11 Version 21H2 (Build 22000.832)
  • launched 1.42.88 Chromium: 104.0.5112.81 using the following:
    • brave.exe --enable-logging=stderr --variations-server-url=https://variations.bravesoftware.com/seed
  • once launched, restarted the browser again and ensured that BraveTranslateStudy wasn't visible via brave://version
  • visited several websites using Polish, German & Spanish and ensured that the prompt re: installing Google Translate appeared as expected
    • also ensured that installing/using the extension worked as expected on the RELEASE channel
BraveTranslateStudy not visible Prompt re: Google translate extension Extension installed
image image image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants