-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update translate code to use a redirection shim #23538
Comments
For QA: we also need to check here a migration from extension based translation: #23155 |
There's no test plan for this or #23155 - mind adding one @atuchin-m or @rebron ? Marking as |
@rebron might be able to help with a test plan also |
@LaurenWags @stephendonner We have a test plan here for all things related to translate: https://docs.google.com/document/d/1hADNy20_UIXMe2vXFrTFfpB5NCGK6hBtNVXJBYIJLds/ Currently, I seems that currently we need to make do some sanity check (without the new flag). @rebron can provide more details. |
thanks @atuchin-m chatted with @rebron - he's going to grab the issue with the test plan for Google translate extension (there were a few iirc) so we can be sure we're checking the correct one. |
Labelling |
During secreview/slack discussion we decided to use current google translate scripts as is via a shim to redirect requests to brave backend.
The code/tests should be updated to use this approach.
The text was updated successfully, but these errors were encountered: