Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update translate code to use a redirection shim #23538

Closed
atuchin-m opened this issue Jun 17, 2022 · 6 comments · Fixed by brave/brave-core#13845
Closed

Update translate code to use a redirection shim #23538

atuchin-m opened this issue Jun 17, 2022 · 6 comments · Fixed by brave/brave-core#13845
Assignees
Labels

Comments

@atuchin-m
Copy link
Contributor

During secreview/slack discussion we decided to use current google translate scripts as is via a shim to redirect requests to brave backend.
The code/tests should be updated to use this approach.

@atuchin-m
Copy link
Contributor Author

For QA: we also need to check here a migration from extension based translation: #23155

@stephendonner
Copy link

stephendonner commented Jul 12, 2022

There's no test plan for this or #23155 - mind adding one @atuchin-m or @rebron ? Marking as QA/Blocked and QA/Test-Plan-Required in the interim. /cc @LaurenWags

@LaurenWags
Copy link
Member

@rebron might be able to help with a test plan also

@atuchin-m
Copy link
Contributor Author

@LaurenWags @stephendonner We have a test plan here for all things related to translate: https://docs.google.com/document/d/1hADNy20_UIXMe2vXFrTFfpB5NCGK6hBtNVXJBYIJLds/

Currently, I seems that currently we need to make do some sanity check (without the new flag).
After we need to do detailed checking using the plan.

@rebron can provide more details.

@LaurenWags
Copy link
Member

thanks @atuchin-m

chatted with @rebron - he's going to grab the issue with the test plan for Google translate extension (there were a few iirc) so we can be sure we're checking the correct one.

@LaurenWags
Copy link
Member

Labelling QA/Blocked pending additional information from @rebron

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants