Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Opening in private using app context menu or shortcut widget does not respect biometrics toggle #7991

Closed
Uni-verse opened this issue Aug 29, 2023 · 1 comment · Fixed by #7992
Closed

Opening in private using app context menu or shortcut widget does not respect biometrics toggle #7991

Uni-verse opened this issue Aug 29, 2023 · 1 comment · Fixed by #7992
Assignees
@soner-yuksel
Labels
bug priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass - iPhone X QA Pass - iPhone QA/Yes release/blocking release-notes/exclude
Milestone
1.57

Comments

@Uni-verse
Copy link
Contributor

Description:

Opening in private using app context menu or shortcut widget does not respect biometrics toggle

Steps to Reproduce

  1. Fresh profile install
  2. From the homescreen, use app context menu and select New Private Tab
  3. From the homescreen, add the brave shortcuts widget, use Private Tab button to open private tab

Actual result:

Biometrics is presented

Expected result:

Should not show biometrics

Reproduces how often: [Easily reproduced, Intermittent Issue]

Always

Brave Version: 1.57 (23.8.29.17)

  • Can you reproduce this issue with the most recent build from TestFlight? Yes
  • Can you reproduce this issue with the previous version of the current build from TestFlight? No
  • Can you reproduce this issue with the current build from AppStore? No (new feature)

Device details:

iPhone, iPad
@Uni-verse Uni-verse added bug priority/P2 A bad problem. We might uplift this to the next planned release. QA/Yes release-notes/exclude release/blocking labels Aug 29, 2023
@Uni-verse Uni-verse added this to the 1.57 milestone Aug 29, 2023
@soner-yuksel soner-yuksel mentioned this issue Aug 29, 2023
Merged
11 tasks
iccub pushed a commit that referenced this issue Aug 29, 2023
@soner-yuksel
Fix #7991: Opening in private using app context menu or shortcut widg…
fc21b32 
…et does not respect biometrics toggle (#7992)

Adding private lock case to the external link open
iccub pushed a commit that referenced this issue Aug 29, 2023
@soner-yuksel @iccub
Fix #7991: Opening in private using app context menu or shortcut widg…
0ea93cf 
…et does not respect biometrics toggle (#7992)

Adding private lock case to the external link open
@Uni-verse Uni-verse mentioned this issue Aug 29, 2023
Closed
@Uni-verse
Copy link
Contributor Author

Verified on iPhone X running iOS 16.5.1 using version 1.57 (28.8.29.19)

arthuredelstein pushed a commit to brave/brave-core that referenced this issue Feb 13, 2024
@soner-yuksel
Fix brave/brave-ios#7991: Opening in private using app context menu o…
8e68ef6 
…r shortcut widget does not respect biometrics toggle (brave/brave-ios#7992)

Adding private lock case to the external link open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@soner-yuksel soner-yuksel

Labels
bug priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass - iPhone X QA Pass - iPhone QA/Yes release/blocking release-notes/exclude
Projects
None yet
Milestone
1.57
2 participants
@soner-yuksel @Uni-verse