Fix #7991: Opening in private using app context menu or shortcut widg…

…et does not respect biometrics toggle (#7992) Adding private lock case to the external link open
brave · Aug 29, 2023 · 0ea93cf · 0ea93cf
1 parent 5f37b47
commit 0ea93cf
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 6 deletions.
diff --git a/Sources/Brave/Frontend/Browser/NavigationRouter.swift b/Sources/Brave/Frontend/Browser/NavigationRouter.swift
@@ -114,10 +114,14 @@ public enum NavigationPath: Equatable {
       if Preferences.Privacy.lockWithPasscode.value {
         bvc.openBlankNewTab(attemptLocationFieldFocus: false, isPrivate: true)
       } else {
-        bvc.askForLocalAuthentication(viewType: .widget) { [weak bvc] success, _ in
-          if success {
-            bvc?.openBlankNewTab(attemptLocationFieldFocus: false, isPrivate: true)
+        if Preferences.Privacy.privateBrowsingLock.value {
+          bvc.askForLocalAuthentication(viewType: .widget) { [weak bvc] success, _ in
+            if success {
+              bvc?.openBlankNewTab(attemptLocationFieldFocus: false, isPrivate: true)
+            }
           }
+        } else {
+          bvc.openBlankNewTab(attemptLocationFieldFocus: false, isPrivate: true)
         }
       }
     case .bookmarks:

diff --git a/Sources/Brave/Frontend/Browser/QuickActions.swift b/Sources/Brave/Frontend/Browser/QuickActions.swift
@@ -63,10 +63,14 @@ public class QuickActions: NSObject {
       if Preferences.Privacy.lockWithPasscode.value {
         handleOpenNewTab(withBrowserViewController: browserViewController, isPrivate: true)
       } else {
-        browserViewController.askForLocalAuthentication(viewType: .widget) { [weak self] success, _ in
-          if success {
-            self?.handleOpenNewTab(withBrowserViewController: browserViewController, isPrivate: true)
+        if Preferences.Privacy.privateBrowsingLock.value {
+          browserViewController.askForLocalAuthentication(viewType: .widget) { [weak self] success, _ in
+            if success {
+              self?.handleOpenNewTab(withBrowserViewController: browserViewController, isPrivate: true)
+            }
           }
+        } else {
+          handleOpenNewTab(withBrowserViewController: browserViewController, isPrivate: true)
         }
       }
     case .scanQRCode: