Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Fix #7991: Opening in private using app context menu or shortcut widget does not respect biometrics toggle #7992

Merged
merged 1 commit into from
Aug 29, 2023

Conversation

soner-yuksel
Copy link
Contributor

@soner-yuksel soner-yuksel commented Aug 29, 2023

Summary of Changes

Adding private lock case to the external link open

This pull request fixes #7991

Submitter Checklist:

  • Unit Tests are updated to cover new or changed functionality
  • User-facing strings use NSLocalizableString()
  • New or updated UI has been tested across:
    • Light & dark mode
    • Different size classes (iPhone, landscape, iPad)
    • Different dynamic type sizes

Test Plan:

  1. Fresh profile install
  2. From the homescreen, use app context menu and select New Private Tab
  3. From the homescreen, add the brave shortcuts widget, use Private Tab button to open private tab

Screenshots:

RPReplay_Final1693335789.MP4

Reviewer Checklist:

  • Issues include necessary QA labels:
    • QA/(Yes|No)
    • bug / enhancement
  • Necessary security reviews have taken place.
  • Adequate unit test coverage exists to prevent regressions.
  • Adequate test plan exists for QA to validate (if applicable).
  • Issue and pull request is assigned to a milestone (should happen at merge time).

@soner-yuksel soner-yuksel requested a review from a team as a code owner August 29, 2023 19:06
@soner-yuksel soner-yuksel changed the title Adding private lock case to the external link open Fix #7991: Opening in private using app context menu or shortcut widget does not respect biometrics toggle Aug 29, 2023
@soner-yuksel soner-yuksel self-assigned this Aug 29, 2023
@soner-yuksel soner-yuksel added this to the 1.57 milestone Aug 29, 2023
@iccub iccub enabled auto-merge (squash) August 29, 2023 19:47
@iccub iccub disabled auto-merge August 29, 2023 20:30
@iccub iccub merged commit fc21b32 into development Aug 29, 2023
@iccub iccub deleted the fix/private-biometric-lock branch August 29, 2023 20:30
iccub pushed a commit that referenced this pull request Aug 29, 2023
…et does not respect biometrics toggle (#7992)

Adding private lock case to the external link open
arthuredelstein pushed a commit to brave/brave-core that referenced this pull request Feb 13, 2024
…r shortcut widget does not respect biometrics toggle (brave/brave-ios#7992)

Adding private lock case to the external link open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Opening in private using app context menu or shortcut widget does not respect biometrics toggle
4 participants