Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Opening in private from home screen will bypass biometrics [Follow up to #7952] #7980

Closed
Uni-verse opened this issue Aug 28, 2023 · 1 comment · Fixed by #7981 or #8011
Closed

Opening in private from home screen will bypass biometrics [Follow up to #7952] #7980

Uni-verse opened this issue Aug 28, 2023 · 1 comment · Fixed by #7981 or #8011
Assignees
Milestone

Comments

@Uni-verse
Copy link
Contributor

Description:

Opening in private from home screen will bypass biometrics [Follow up to #7952]

Case 1 Case 2
IMG_1172 IMG_3487

Steps to Reproduce

  1. Enable Require Face ID in private tabs settings
  2. Kill app
  3. From the home screen, long press on Brave app and select New Private Tab
  4. Confirm biometrics is required
  5. Add the Brave Shortcuts Widget to the home screen, tap on the Private Tab button
  6. Confirm biometrics is required

Actual result:

No biometrics is required

Expected result:

biometrics should be required

Reproduces how often: [Easily reproduced, Intermittent Issue]

Always

Brave Version: 1.57 (23.8.28.22)

  • Can you reproduce this issue with the most recent build from TestFlight? Yes
  • Can you reproduce this issue with the previous version of the current build from TestFlight? Yes
  • Can you reproduce this issue with the current build from AppStore? No (new feature)

Device details:

iPhone, iPad, all versions

@Uni-verse
Copy link
Contributor Author

Uni-verse commented Aug 29, 2023

Verified on iPhone X running iOS 16.5.1 using version 1.57 (23.8.29.17)

Encountered: #7991

soner-yuksel added a commit that referenced this issue Sep 1, 2023
iccub pushed a commit that referenced this issue Sep 1, 2023
arthuredelstein pushed a commit to brave/brave-core that referenced this issue Feb 13, 2024
… in private from home screen will bypass biometrics (brave/brave-ios#7981)
arthuredelstein pushed a commit to brave/brave-core that referenced this issue Feb 13, 2024
… in private from home screen will bypass biometrics (brave/brave-ios#8011)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.