Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Opening link in private tab will bypass biometrics authentication #7952

Closed
Uni-verse opened this issue Aug 24, 2023 · 1 comment · Fixed by #7959
Closed

Opening link in private tab will bypass biometrics authentication #7952

Uni-verse opened this issue Aug 24, 2023 · 1 comment · Fixed by #7959

Comments

@Uni-verse
Copy link
Contributor

Uni-verse commented Aug 24, 2023

Description:

Opening link in private tab will bypass biometrics authentication

There are 2 use cases to investigate

Case 1: Opening link in private tab from context menu.
Case 2: Opening a link in new private window mode. This only pertains to iPad since iPhone does not support this. Such a context menu is available on webpage when long pressing on link.

Steps to Reproduce

  1. Install 1.57.x
  2. Open menu and scroll down to the TABS section
  3. Tap on Private Tabs Settings
  4. Enable Require Face ID for Private tabs
  5. Return to NTP
  6. Long press on favorite, select Open in New Private Tab
  7. Observe tab mode switch

Actual result:

RPReplay_Final1692904243.MP4

Expected result:

Should require biometrics authentication like when switch to private mode from tab view.

Reproduces how often: [Easily reproduced, Intermittent Issue]

Always

Brave Version: 1.57 (23.8.24.17)

  • Can you reproduce this issue with the most recent build from TestFlight? Yes
  • Can you reproduce this issue with the previous version of the current build from TestFlight? Yes
  • Can you reproduce this issue with the current build from AppStore? No (new feature)

Device details:

iPhone X, 16.5.1
iPad, 16.5.1

@Uni-verse
Copy link
Contributor Author

Verified on iPhone X running iOS 16.5.1 & iPad (7th Gen) running iPadOS 16.5.1 using version 1.57 (23.8.28.22)

iPhoneiPad
RPReplay_Final1693262969.MP4
RPReplay_Final1693262691.MP4

soner-yuksel added a commit that referenced this issue Aug 29, 2023
iccub pushed a commit that referenced this issue Aug 29, 2023
soner-yuksel added a commit that referenced this issue Sep 1, 2023
iccub pushed a commit that referenced this issue Sep 1, 2023
arthuredelstein pushed a commit to brave/brave-core that referenced this issue Feb 13, 2024
arthuredelstein pushed a commit to brave/brave-core that referenced this issue Feb 13, 2024
… in private from home screen will bypass biometrics (brave/brave-ios#7981)
arthuredelstein pushed a commit to brave/brave-core that referenced this issue Feb 13, 2024
… in private from home screen will bypass biometrics (brave/brave-ios#8011)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants