Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Fix #7952: Opening link in private tab will bypass biometrics authentication #7959

Merged
merged 5 commits into from
Aug 28, 2023

Conversation

soner-yuksel
Copy link
Contributor

@soner-yuksel soner-yuksel commented Aug 25, 2023

Summary of Changes

The conditions of opening in private tab is handled

  • Context menu open in private tab
  • Context menu open in private window
  • Playlist context menu open in new private tab
  • Playlist share open in new private tab
  • NTP favourite open in new private tab
  • NTP favourite show more open in private tab
  • Bookmarks open in a new private tab
  • History open in new private tab
  • Bottom bar long press middle icon action open in new private tab
  • News open in new Private tab

This pull request fixes #7952

Submitter Checklist:

  • Unit Tests are updated to cover new or changed functionality
  • User-facing strings use NSLocalizableString()
  • New or updated UI has been tested across:
    • Light & dark mode
    • Different size classes (iPhone, landscape, iPad)
    • Different dynamic type sizes

Test Plan:

The test plan is determined in the ticket

Screenshots:

Context menu open in private tab - Context menu open in private window

RPReplay_Final1693231040.MP4

Playlist context menu open in private tab
- Playlist share open in private tab

RPReplay_Final1693231300.MP4

NTP favourite open in private new tab - NTP favourite show more open in new private tab

RPReplay_Final1693231447.MP4

Bookmarks open in a new private tab

RPReplay_Final1693232666.MP4

History open in new private tab

RPReplay_Final1693232928.MP4

Bottom bar long press middle icon action open in new private tab

RPReplay_Final1693233103.MP4

News open in new private tab

RPReplay_Final1693233324.MP4

Reviewer Checklist:

  • Issues include necessary QA labels:
    • QA/(Yes|No)
    • bug / enhancement
  • Necessary security reviews have taken place.
  • Adequate unit test coverage exists to prevent regressions.
  • Adequate test plan exists for QA to validate (if applicable).
  • Issue and pull request is assigned to a milestone (should happen at merge time).

@soner-yuksel soner-yuksel added bug priority/P2 A bad problem. We might uplift this to the next planned release. labels Aug 25, 2023
@soner-yuksel soner-yuksel added this to the 1.57 milestone Aug 25, 2023
@soner-yuksel soner-yuksel requested a review from a team as a code owner August 25, 2023 00:55
@soner-yuksel soner-yuksel self-assigned this Aug 25, 2023
@soner-yuksel soner-yuksel force-pushed the fix/private-authentication-error branch from 14ca368 to 21610ec Compare August 28, 2023 02:20
@soner-yuksel
Copy link
Contributor Author

All scenarios are tested after the changes and there is video uploaded in description for all of them

@soner-yuksel soner-yuksel merged commit 8653b0f into development Aug 28, 2023
@soner-yuksel soner-yuksel deleted the fix/private-authentication-error branch August 28, 2023 16:12
iccub pushed a commit that referenced this pull request Aug 28, 2023
arthuredelstein pushed a commit to brave/brave-core that referenced this pull request Feb 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug priority/P2 A bad problem. We might uplift this to the next planned release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Opening link in private tab will bypass biometrics authentication
2 participants