This repository has been archived by the owner on May 10, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 442
Fix #7952: Opening link in private tab will bypass biometrics authentication #7959
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soner-yuksel
added
bug
priority/P2
A bad problem. We might uplift this to the next planned release.
labels
Aug 25, 2023
kylehickinson
suggested changes
Aug 25, 2023
Sources/Brave/Frontend/Browser/New Tab Page/NewTabPageViewController.swift
Outdated
Show resolved
Hide resolved
Sources/Brave/Frontend/Browser/Favorites/FavoritesViewController.swift
Outdated
Show resolved
Hide resolved
...ave/Frontend/Browser/Playlist/Controllers/PlaylistListViewController+TableViewDelegate.swift
Outdated
Show resolved
Hide resolved
soner-yuksel
force-pushed
the
fix/private-authentication-error
branch
from
August 28, 2023 02:20
14ca368
to
21610ec
Compare
All scenarios are tested after the changes and there is video uploaded in description for all of them |
kylehickinson
suggested changes
Aug 28, 2023
...ave/Frontend/Browser/Playlist/Controllers/PlaylistListViewController+TableViewDelegate.swift
Outdated
Show resolved
Hide resolved
kylehickinson
approved these changes
Aug 28, 2023
iccub
pushed a commit
that referenced
this pull request
Aug 28, 2023
arthuredelstein
pushed a commit
to brave/brave-core
that referenced
this pull request
Feb 13, 2024
…metrics authentication (brave/brave-ios#7959)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
The conditions of opening in private tab is handled
This pull request fixes #7952
Submitter Checklist:
NSLocalizableString()
Test Plan:
The test plan is determined in the ticket
Screenshots:
Context menu open in private tab - Context menu open in private window
RPReplay_Final1693231040.MP4
Playlist context menu open in private tab - Playlist share open in private tab
RPReplay_Final1693231300.MP4
NTP favourite open in private new tab - NTP favourite show more open in new private tab
RPReplay_Final1693231447.MP4
Bookmarks open in a new private tab
RPReplay_Final1693232666.MP4
History open in new private tab
RPReplay_Final1693232928.MP4
Bottom bar long press middle icon action open in new private tab
RPReplay_Final1693233103.MP4
News open in new private tab
RPReplay_Final1693233324.MP4
Reviewer Checklist:
QA/(Yes|No)
bug
/enhancement