Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Add ability to reveal wallet password on unlock #7181

Open
StephenHeaps opened this issue Mar 31, 2023 · 2 comments · Fixed by #7269
Open

Add ability to reveal wallet password on unlock #7181

StephenHeaps opened this issue Mar 31, 2023 · 2 comments · Fixed by #7269
Labels
Epic: Brave Wallet QA/Yes

Comments

@StephenHeaps
Copy link
Contributor

StephenHeaps commented Mar 31, 2023 •
edited
Loading

Description:

We should add a button/toggle to show/hide password

ref: https://bravesoftware.slack.com/archives/C023VS4HJ6Q/p1666185103959729
ref #2: https://bravesoftware.slack.com/archives/C023VS4HJ6Q/p1695925899009109?thread_ts=1695912331.946559&cid=C023VS4HJ6Q

https://www.figma.com/file/oXIiv45pIhF2RGlpEjOfUg/Wallet-onboarding?type=design&node-id=6234%3A45645&mode=design&t=WgEPNGFw5QmUuWZ1-1
@StephenHeaps StephenHeaps moved this to Backlog in Web3 Mar 31, 2023
@StephenHeaps StephenHeaps mentioned this issue Mar 31, 2023
Closed
@StephenHeaps StephenHeaps mentioned this issue Apr 17, 2023
Merged
11 tasks
@StephenHeaps StephenHeaps self-assigned this Apr 19, 2023
@StephenHeaps StephenHeaps moved this from Backlog to In Review in Web3 Apr 19, 2023
StephenHeaps added a commit that referenced this issue May 1, 2023
@StephenHeaps
Fix #7113, #7181: Ability to reveal password during wallet unlock, re…
6122a2d 
…store, and create (#7269)

* Add `RevealableSecureField` password field for Unlock, Create and Restoring wallet.
Hide password (if revealed) before populating unlock wallet password field with stored password.
Hide recovery phrase (if revealed) before revealing wallet password when restoring wallet from recovery phrase.

* Move Biometrics button below Unlock/Restore buttons when unlocking wallet. Don't focus keyboard when pre-filling password via biometrics.

* Disable autocapitalization in recovery phrase field
@github-project-automation github-project-automation bot moved this from In Review to Done in Web3 May 1, 2023
@StephenHeaps StephenHeaps added this to the 1.51 milestone May 8, 2023
@hffvld hffvld mentioned this issue May 8, 2023
Closed
@hffvld
Copy link
Collaborator

hffvld commented May 8, 2023

Verified on iPhone 14 and iPad Air using version(s):

Device/OS: iPhone 14 [iOS 16.4.1] and iPad Air [iPadOS 16.4.1]
Version: 1.51 (23.5.8.16) 
BraveCore: 1.51.110 (113.0.5672.77)

Filed follow-up issue #7416

3rd-party keyboard - FAIL

PRECONDITIONS:

  • Install a 3rd-party keyboard, for example, Gboard

STEPS:

Create Wallet

  1. Launch Brave > Three dot Menu > Wallet
  2. Get Started > Tap in the Password field > Verify that Apple keyboard is shown
  3. Tap and hold Globus thumbnail > Verify there is no option to show Gboard
  4. Verify the same for the Verify password field

Unlock

  1. Launch Brave > Three dot Menu > Wallet
  2. Tap in the Password field > Verify that Apple keyboard is showing
  3. Tap and hold Globus thumbnail > Verify there is no option to show Gboard

Restore

  1. Launch Brave > Three dot Menu > Wallet
  2. Tap Restore Tap in the Recovery Phrase field > Verify that Apple keyboard is showing
  3. Tap and hold Globus thumbnail > Verify there is no option to show Gboard
  4. Repeat the same for the Password and Verify password text fields

ACTUAL RESULTS:

  • Verified that 3rd-party keyboard is not shown for the text fields on the Create (setup new wallet), Unlock and Restore screens
1 2 3
1 2 3
Password reveal/hide - PASS

STEPS:

  1. Launch Brave > Three dot Menu > Wallet
  2. Get Started > Tap in the Password field > Type password > Tap Eye thumbnail > Verify
  3. Repeat the same for the Verify password text field

ACTUAL RESULTS:

  • Verified that the password is revealed when the Eye thumbnail is tapped, and hidden when the Crossed-eye thumbnail is tapped
Wallet_Password.reveal.mov
Biometric unlock - PASS

STEPS:

  1. Launch Brave > Three dot Menu > Wallet
  2. Use Biometric unlock > Verify

ACTUAL RESULTS:

  • Verified that auto-filling password via biometrics is hiding/masking the password before auto-filling it.
Wallet_No.password.when.face.unlock.mov

@hffvld
Copy link
Collaborator

hffvld commented May 8, 2023

Filed follow-up issue #7416

StephenHeaps added a commit that referenced this issue May 10, 2023
@StephenHeaps
Revert "Fix #7113, #7181: Ability to reveal password during wallet un…
1d005f6 
…lock, restore, and create (#7269)"

This reverts commit 6122a2d.
iccub pushed a commit that referenced this issue May 10, 2023
@StephenHeaps
Revert #7269: Wallet reveal password field (#7427)
b293ff8 
* Revert "Fix #7113, #7181: Ability to reveal password during wallet unlock, restore, and create (#7269)"

This reverts commit 6122a2d.

* Revert #7382 - auto-focus password field in unlock wallet
iccub pushed a commit that referenced this issue May 10, 2023
@StephenHeaps @iccub
Revert #7269: Wallet reveal password field (#7427)
cb04084 
* Revert "Fix #7113, #7181: Ability to reveal password during wallet unlock, restore, and create (#7269)"

This reverts commit 6122a2d.

* Revert #7382 - auto-focus password field in unlock wallet
@StephenHeaps StephenHeaps reopened this May 10, 2023
@StephenHeaps StephenHeaps removed this from the 1.51 milestone May 10, 2023
@StephenHeaps StephenHeaps moved this from Done to Backlog in Web3 May 10, 2023
@StephenHeaps StephenHeaps removed their assignment Jul 24, 2023
arthuredelstein pushed a commit to brave/brave-core that referenced this issue Feb 13, 2024
@StephenHeaps
Fix brave/brave-ios#7113, brave/brave-ios#7181: Ability to reveal pas…
b06fedf 
…sword during wallet unlock, restore, and create (brave/brave-ios#7269)

* Add `RevealableSecureField` password field for Unlock, Create and Restoring wallet.
Hide password (if revealed) before populating unlock wallet password field with stored password.
Hide recovery phrase (if revealed) before revealing wallet password when restoring wallet from recovery phrase.

* Move Biometrics button below Unlock/Restore buttons when unlocking wallet. Don't focus keyboard when pre-filling password via biometrics.

* Disable autocapitalization in recovery phrase field
arthuredelstein pushed a commit to brave/brave-core that referenced this issue Feb 13, 2024
@StephenHeaps
Revert brave/brave-ios#7269: Wallet reveal password field (brave/brav…
414fe1a 
…e-ios#7427)

* Revert "Fix brave/brave-ios#7113, brave/brave-ios#7181: Ability to reveal password during wallet unlock, restore, and create (brave/brave-ios#7269)"

This reverts commit 6122a2d.

* Revert brave/brave-ios#7382 - auto-focus password field in unlock wallet
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Epic: Brave Wallet QA/Yes
Projects
Web3
Status: Backlog
Milestone
No milestone
2 participants
@StephenHeaps @hffvld