Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

On Wallet Reset flow, you should be able to reveal the password #7113

Open
HEagle18 opened this issue Mar 20, 2023 · 1 comment · Fixed by #7269
Open

On Wallet Reset flow, you should be able to reveal the password #7113

HEagle18 opened this issue Mar 20, 2023 · 1 comment · Fixed by #7269
Labels
Epic: Brave Wallet QA/Yes

Comments

@HEagle18
Copy link

HEagle18 commented Mar 20, 2023 •
edited by StephenHeaps
Loading

Description:

When you are restoring your wallet, when you are creating or reusing a password, it doesn't give you the option to see the password you are entering or have entered. This important for users who have sophsictaced passwords

Steps to Reproduce

  1. Restore wallet on iOS
  2. enter in recovery phrase
  3. try entereing in wallet

Actual result:

this page
IMG_7891

Expected result:

it should give you an option to see the password that you have entered

Reproduces how often: [Easily reproduced, Intermittent Issue]

Brave Version:

  • Can you reproduce this issue with the most recent build from TestFlight?
  • Can you reproduce this issue with the previous version of the current build from TestFlight?
  • Can you reproduce this issue with the current build from AppStore?

Device details:

Website problems only:

  • did you check with Brave Shields down?
  • did you check in Safari/Firefox (WkWebView-based browsers)?

Additional Information

ref: https://bravesoftware.slack.com/archives/C023VS4HJ6Q/p1695925899009109?thread_ts=1695912331.946559&cid=C023VS4HJ6Q

https://www.figma.com/file/oXIiv45pIhF2RGlpEjOfUg/Wallet-onboarding?type=design&node-id=6234%3A45645&mode=design&t=WgEPNGFw5QmUuWZ1-1
@HEagle18 HEagle18 added this to Web3 Mar 20, 2023
@HEagle18 HEagle18 moved this to Backlog in Web3 Mar 24, 2023
@StephenHeaps StephenHeaps mentioned this issue Apr 17, 2023
Merged
11 tasks
@StephenHeaps StephenHeaps self-assigned this Apr 19, 2023
@StephenHeaps StephenHeaps moved this from Backlog to In Review in Web3 Apr 19, 2023
StephenHeaps added a commit that referenced this issue May 1, 2023
@StephenHeaps
Fix #7113, #7181: Ability to reveal password during wallet unlock, re…
6122a2d 
…store, and create (#7269)

* Add `RevealableSecureField` password field for Unlock, Create and Restoring wallet.
Hide password (if revealed) before populating unlock wallet password field with stored password.
Hide recovery phrase (if revealed) before revealing wallet password when restoring wallet from recovery phrase.

* Move Biometrics button below Unlock/Restore buttons when unlocking wallet. Don't focus keyboard when pre-filling password via biometrics.

* Disable autocapitalization in recovery phrase field
@github-project-automation github-project-automation bot moved this from In Review to Done in Web3 May 1, 2023
@StephenHeaps StephenHeaps added this to the 1.51 milestone May 8, 2023
@hffvld
Copy link
Collaborator

hffvld commented May 8, 2023

Verified on iPhone 14 and iPad Air using version(s):

Device/OS: iPhone 14 [iOS 16.4.1] and iPad Air [iPadOS 16.4.1]
Version: 1.51 (23.5.8.16) 
BraveCore: 1.51.110 (113.0.5672.77)

STEPS:

  1. Launch Brave
  2. Three dot Menu > Wallet > Restore
  3. Enter a password in the Password and Verify password fields
  4. Tap the Eye icon

ACTUAL RESULTS:

  • Verified that the user can see the entered password in both Password and Verify password fields now when tapping on the Eye icon
1 2
1 2

StephenHeaps added a commit that referenced this issue May 10, 2023
@StephenHeaps
Revert "Fix #7113, #7181: Ability to reveal password during wallet un…
1d005f6 
…lock, restore, and create (#7269)"

This reverts commit 6122a2d.
iccub pushed a commit that referenced this issue May 10, 2023
@StephenHeaps
Revert #7269: Wallet reveal password field (#7427)
b293ff8 
* Revert "Fix #7113, #7181: Ability to reveal password during wallet unlock, restore, and create (#7269)"

This reverts commit 6122a2d.

* Revert #7382 - auto-focus password field in unlock wallet
iccub pushed a commit that referenced this issue May 10, 2023
@StephenHeaps @iccub
Revert #7269: Wallet reveal password field (#7427)
cb04084 
* Revert "Fix #7113, #7181: Ability to reveal password during wallet unlock, restore, and create (#7269)"

This reverts commit 6122a2d.

* Revert #7382 - auto-focus password field in unlock wallet
@StephenHeaps StephenHeaps reopened this May 10, 2023
@StephenHeaps StephenHeaps removed this from the 1.51 milestone May 10, 2023
@StephenHeaps StephenHeaps moved this from Done to Backlog in Web3 May 10, 2023
@StephenHeaps StephenHeaps removed their assignment Jul 24, 2023
arthuredelstein pushed a commit to brave/brave-core that referenced this issue Feb 13, 2024
@StephenHeaps
Fix brave/brave-ios#7113, brave/brave-ios#7181: Ability to reveal pas…
b06fedf 
…sword during wallet unlock, restore, and create (brave/brave-ios#7269)

* Add `RevealableSecureField` password field for Unlock, Create and Restoring wallet.
Hide password (if revealed) before populating unlock wallet password field with stored password.
Hide recovery phrase (if revealed) before revealing wallet password when restoring wallet from recovery phrase.

* Move Biometrics button below Unlock/Restore buttons when unlocking wallet. Don't focus keyboard when pre-filling password via biometrics.

* Disable autocapitalization in recovery phrase field
arthuredelstein pushed a commit to brave/brave-core that referenced this issue Feb 13, 2024
@StephenHeaps
Revert brave/brave-ios#7269: Wallet reveal password field (brave/brav…
414fe1a 
…e-ios#7427)

* Revert "Fix brave/brave-ios#7113, brave/brave-ios#7181: Ability to reveal password during wallet unlock, restore, and create (brave/brave-ios#7269)"

This reverts commit 6122a2d.

* Revert brave/brave-ios#7382 - auto-focus password field in unlock wallet
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Epic: Brave Wallet QA/Yes
Projects
Web3
Status: Backlog
Milestone
No milestone
3 participants
@StephenHeaps @HEagle18 @hffvld