Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

[Wallet][Follow up to #7181] 3rd-party keyboard is shown when tapping an "Eye" button to reveal the password #7416

Closed
hffvld opened this issue May 8, 2023 · 1 comment · Fixed by #7427

Comments

@hffvld
Copy link
Collaborator

hffvld commented May 8, 2023

Description:

Follow up to #7181

Steps to Reproduce

  1. Install a 3rd-party keyboard, for example, Gboard
  2. Launch Brave > Three dot Menu > Wallet
  3. Tap on any password field > Enter the password using Apple keyboard
  4. Tap the Eye button to reveal the password > Observe, that Gboard is shown

Actual result:

The 3rd-party keyboard is shown each time when a user is tapping the Eye button to reveal the password

Wallet_Gboard.is.shown.mov

Expected result:

3rd-party keyboards must not be shown for the password fields

Reproduces how often: [Easily reproduced, Intermittent Issue]

Easily reproduced

Brave Version:

Version: 1.51 (23.5.8.18)
BraveCore: 1.51.110 (113.0.5672.77)

  • Can you reproduce this issue with the most recent build from TestFlight? Yes
  • Can you reproduce this issue with the previous version of the current build from TestFlight? Yes
  • Can you reproduce this issue with the current build from AppStore? N/A

Device details:

iPhone 14 [iOS 16.4.1]

Website problems only:

  • did you check with Brave Shields down?
  • did you check in Safari/Firefox (WkWebView-based browsers)?

Additional Information

@hffvld
Copy link
Collaborator Author

hffvld commented May 11, 2023

Verified on iPhone 14 and iPad Air using version(s):

Device/OS: iPhone 14 [iOS 16.4.1] and iPad Air [iPadOS 16.4.1]
Version: 1.51 (23.5.11.15)
BraveCore: 1.51.114 (113.0.5672.92)

STEPS:

  1. Install a 3rd-party keyboard, for example, Gboard
  2. Launch Brave > Three dot Menu > Wallet
  3. Tap on any password field > Enter the password using Apple keyboard
  4. Try to switch keyboards by tapping the Globe

ACTUAL RESULTS:

  • Verified 3rd-party keyboards are not shown
  • Verified Eye icon is not shown again
1 2 3
1 2 3

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants