Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Wallet is using an obsolete password policy #6093

Closed
srirambv opened this issue Oct 3, 2022 · 2 comments · Fixed by #7182
Closed

Wallet is using an obsolete password policy #6093

srirambv opened this issue Oct 3, 2022 · 2 comments · Fixed by #7182
Assignees
@StephenHeaps
Labels
Epic: Brave Wallet QA Pass - iPhone X QA/Yes release-notes/include
Milestone
1.60

Comments

@srirambv
Copy link
Contributor

srirambv commented Oct 3, 2022

iOS version of brave/brave-browser#22817
@StephenHeaps
Copy link
Contributor

StephenHeaps commented Dec 16, 2022 •
edited
Loading

We should add a button/toggle to show/hide password with this ticket.
Separated to: #7181

@StephenHeaps StephenHeaps self-assigned this Mar 27, 2023
@StephenHeaps StephenHeaps mentioned this issue Mar 31, 2023
Merged
11 tasks
StephenHeaps added a commit that referenced this issue Apr 3, 2023
@StephenHeaps
Fix #6093: Update wallet password policy (#7182)
ffb880e 
Update wallet password policy, add unit tests (no longer using `KeyringService` function).
Brandon-T pushed a commit that referenced this issue Apr 11, 2023
@StephenHeaps @Brandon-T
Fix #6093: Update wallet password policy (#7182)
99622de 
Update wallet password policy, add unit tests (no longer using `KeyringService` function).
@iccub iccub added this to the 1.59 milestone Oct 6, 2023
@srirambv
Copy link
Contributor Author

srirambv commented Nov 9, 2023

Verification passed on iPhone 13 with iOS 17.2 running 1.60(23.11.7.17)

  • Verified steps from #7182
  • Verified minimum password length message is shown on both new wallet creation and when restoring wallet

@Uni-verse Uni-verse mentioned this issue Dec 20, 2023
Closed
arthuredelstein pushed a commit to brave/brave-core that referenced this issue Feb 13, 2024
@StephenHeaps
Fix brave/brave-ios#6093: Update wallet password policy (brave/brave-…
f7cb31e 
…ios#7182)

Update wallet password policy, add unit tests (no longer using `KeyringService` function).
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@StephenHeaps StephenHeaps

Labels
Epic: Brave Wallet QA Pass - iPhone X QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.60
Development

Successfully merging a pull request may close this issue.

Fix #6093: Update wallet password policy brave/brave-ios
3 participants
@StephenHeaps @iccub @srirambv