Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Auto-upgrade of Youtube video resolution #7055

Closed
kevincolyar opened this issue Mar 6, 2023 · 4 comments · Fixed by #7550
Closed

Auto-upgrade of Youtube video resolution #7055

kevincolyar opened this issue Mar 6, 2023 · 4 comments · Fixed by #7550

Comments

@kevincolyar
Copy link

Description:

When using the mobile version of the YouTube website in fullscreen mode, rotating the screen should upgrade the resolution from 360p to 720p.

At one point (late fall of 2022?) I believe this was working on Brave iOS but appears to have reverted back to the old way of handling YouTube video resolution.

Steps to Reproduce

  1. Play video on YouTube mobile website (notice resolution is set to Auto (360p in my case).
  2. Enter fullscreen
  3. Video resolution does not improve.

Actual result:

Video resolution stays at 360p.

Expected result:

Video resolution should improve to 720p.

Reproduces how often: [Easily reproduced, Intermittent Issue]

Easily reproduced.

Brave Version: 1.48.1 (23.3.2.0)

  • Can you reproduce this issue with the most recent build from TestFlight?
    Don't have TestFlight.

  • Can you reproduce this issue with the previous version of the current build from TestFlight?
    Dont have TestFlight.

  • Can you reproduce this issue with the current build from AppStore?
    Yes

Device details: iPhone SE 2020 iOS 16.3.1

Website problems only:

  • did you check with Brave Shields down?
    Yes

  • did you check in Safari/Firefox (WkWebView-based browsers)?
    No, I only use Brave.

Additional Information

@kevincolyar kevincolyar changed the title Auto-upgrade of video resolution of Youtube videos Auto-upgrade of Youtube video resolution Mar 6, 2023
@Brandon-T Brandon-T self-assigned this Mar 10, 2023
@iccub iccub modified the milestones: 1.52, 1.53 Jun 12, 2023
@anthonypkeane
Copy link

anthonypkeane commented Jun 28, 2023

Please place this setting under GENERAL , Block Popups

STREAMING PLAYBACK
Enable Playback at Max Quality
-> Display the value as we do for Appearance

Tapping on Enable Playback at Max Quality take the user to a screen where we display the following

Title: STREAMING PLAYBACK
Off
Allow over Wi-Fi
Allow over Cellular
Description:
Enabling this experimental feature will playback YouTube video at the maximum quality available and may use additional data.

The user can check either Off, Allow over Wi-Fi or Allow over Cellular as they can in the Podcast setting (image below for reference)

Cellular should automatically localize to Mobile given the users region.

@aguscruiz can you please provide an icon for ^

@iccub if we can combine #7654 with this ticket it will clean the menu up a bit.

Thanks

Example
IMG_990082B65CBC-1

IMG_990082B65CBC-2
IMG_F206ADDF2549-1

@hffvld
Copy link
Collaborator

hffvld commented Jul 21, 2023

Verified on iPhone 14using version(s):

Device/OS: iPhone 14 [iOS 16.5.1]
Brave build: 1.56 (23.7.19.18)
BraveCore: 1.56.6 (115.0.5790.90)

Filed follow-up issue #7769 and #7771

STEPS:

  1. Launch Brave
  2. Three-dot menu > Settings
  3. Open Media under DISPLAY section
  4. Find YOUTUBE section > Tap Highest Quality Playback > Verify
  5. Go back and open www.youtube.com > Play any video
  6. Tap ⚙︎ icon > Verify
  7. Go back to Highest Quality Playback screen and change the setting to Always on > Verify video playback
  8. Repeat Step 7, but this time enable Only while using WiFi

ACTUAL RESULTS:

  • Verified that the new YouTube section appeared under DISPLAY > Media
  • Verified that the default preset is set to Off for the Highest Quality Playback
  • Verified pop-up menu UI for a separate video on www.youtube.com
  • Verified when Highest Quality Playback is set to Off, default video quality is set to Auto (360p)
  • Verified when Always on or Only while using WiFi is ON, video quality is set to 720p automatically (in 720p is available for the video)

1 2 3
1 2 3
4 5 6
4 5 6
720p.mov

@anthonypkeane
Copy link

@iccub

Pls change
Allows desktop-quality resolution
for
Allows high-quality resolution

Pls update the settings options to:
On
Allow over Wi-Fi (enabled default)
Off

@iccub
Copy link
Contributor

iccub commented Jul 25, 2023

Copy and default behavior tracked here #7776

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants