Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

[Follow up to #7055] Video quality not always set to "720p" even if it enabled in the settings #7771

Closed
hffvld opened this issue Jul 21, 2023 · 1 comment · Fixed by #7774

Comments

@hffvld
Copy link
Collaborator

hffvld commented Jul 21, 2023

Description:

Follow-up to #7055

Steps to Reproduce

  1. Launch Brave
  2. Three-dot menu > Settings
  3. Open Media under DISPLAY section
  4. Find YOUTUBE section > Tap Highest Quality Playback > Enable Always on
  5. Go back and open www.youtube.com > Play any video
  6. Tap ⚙︎ icon > Observe that quality is still set to Auto (360p)
  7. If it is set to the expected 720p, try to play a few more videos and check the Gear icon each time

Actual result:

Sometimes the video quality is set to Auto (360p) even if Always on is enabled in the Highest Quality Playback settings. If you manually refresh the page, then the video quality will be set to 720p (time stamp ~20s - 30s in the video).

720p.mov

Expected result:

When Always on (Only when using WiFi) is enabled in the Highest Quality Playback settings, the default video quality must be set to 720p if that resolution is available for the video.

Reproduces how often: [Easily reproduced, Intermittent Issue]

Easily reproduced

Brave Version:

Brave build: 1.56 (23.7.19.18)
BraveCore: 1.56.6 (115.0.5790.90)

  • Can you reproduce this issue with the most recent build from TestFlight? Yes
  • Can you reproduce this issue with the previous version of the current build from TestFlight? NA
  • Can you reproduce this issue with the current build from AppStore? NA

Device details:

Device/OS: iPhone 14 [iOS 16.5.1]

Website problems only:

  • did you check with Brave Shields down?
  • did you check in Safari/Firefox (WkWebView-based browsers)?

Additional Information

@iccub iccub self-assigned this Jul 24, 2023
iccub added a commit that referenced this issue Jul 24, 2023
From my tests, getAvailableQualityLevels sometimes returns an empty array.
In this case we should try again few times before going with default option.
@iccub iccub added this to the 1.56 milestone Jul 28, 2023
@hffvld
Copy link
Collaborator Author

hffvld commented Aug 1, 2023

Verified on iPhone 14 using version(s):

Device/OS: iPhone 14 [iOS 16.6]
Brave build: 1.56 (23.7.31.17)
BraveCore: 1.56.13 (115.0.5790.136)

STEPS:
Followed the steps from #7771 (comment)

ACTUAL RESULTS:

  • Verified that playback quality is set to 720p for all videos that are supporting it if Highest quality playback is ON.

2023-08-01_12-45-12.mp4

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants