Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Media Settings copy update #7776

Closed
iccub opened this issue Jul 24, 2023 · 1 comment · Fixed by #7777
Closed

Media Settings copy update #7776

iccub opened this issue Jul 24, 2023 · 1 comment · Fixed by #7777
Assignees
@iccub
Labels
enhancement QA Pass - iPad QA Pass - iPhone X QA/Yes release-notes/include
Milestone
1.56

Comments

@iccub
Copy link
Contributor

iccub commented Jul 24, 2023 •
edited
Loading

per #7055 (comment)

Pls change
Allows desktop-quality resolution
for
Allows high-quality resolution

Pls update the settings options to:
On
Allow over Wi-Fi (enabled default)
Off
@iccub iccub added this to the 1.56 milestone Jul 24, 2023
@iccub iccub mentioned this issue Jul 25, 2023
Closed
@iccub iccub self-assigned this Jul 25, 2023
iccub added a commit that referenced this issue Jul 25, 2023
@iccub
Fix #7776: YT auto quality copy and default setting update.
3f97f70 
The default now is to allow when using wi-fi
@iccub iccub mentioned this issue Jul 25, 2023
Merged
11 tasks
iccub added a commit that referenced this issue Jul 25, 2023
@iccub
Fix #7776: YT auto quality copy and default setting update. (#7777)
1621dcf
iccub added a commit that referenced this issue Jul 25, 2023
@iccub
Fix #7776: YT auto quality copy and default setting update. (#7777)
6ccc01e
@Uni-verse
Copy link
Contributor

Uni-verse commented Jul 27, 2023 •
edited
Loading

Verified on iPhone X running iOS 16.5.1 & iPad (9th Gen) running iPadOS 15.6.1 using version 1.56 (23.7.25.16)

Acceptance Criteria: #7776 (comment)

  • Verified copy updated to Allows high-quality resolution
  • Verified Allow over Wi-Fi set as default for Quality Settings page
  • Verified copy changes to options on Quality Settings page
Example Example
IMG_3372 IMG_3373
IMG_0315 2 IMG_0316 3

@Uni-verse Uni-verse mentioned this issue Nov 10, 2023
Closed
arthuredelstein pushed a commit to brave/brave-core that referenced this issue Feb 13, 2024
@iccub
Fix brave/brave-ios#7776: YT auto quality copy and default setting up…
19e28b8 
…date. (brave/brave-ios#7777)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@iccub iccub

Labels
enhancement QA Pass - iPad QA Pass - iPhone X QA/Yes release-notes/include
Projects
None yet
Milestone
1.56
Development

Successfully merging a pull request may close this issue.

Fix #7776: YT auto quality copy and default setting update. brave/brave-ios
2 participants
@iccub @Uni-verse