Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Fix #7055: Enable Highest Quality Youtube Videos #7550

Merged
merged 4 commits into from
Jun 12, 2023

Conversation

Brandon-T
Copy link
Collaborator

@Brandon-T Brandon-T commented May 31, 2023

Summary of Changes

  • Adds a preference to make Youtube render the highest quality videos by default.

This pull request fixes #7055

Submitter Checklist:

  • Unit Tests are updated to cover new or changed functionality
  • User-facing strings use NSLocalizableString()
  • New or updated UI has been tested across:
    • Light & dark mode
    • Different size classes (iPhone, landscape, iPad)
    • Different dynamic type sizes

Screenshots:

image image

Reviewer Checklist:

  • Issues include necessary QA labels:
    • QA/(Yes|No)
    • bug / enhancement
  • Necessary security reviews have taken place.
  • Adequate unit test coverage exists to prevent regressions.
  • Adequate test plan exists for QA to validate (if applicable).
  • Issue and pull request is assigned to a milestone (should happen at merge time).

@Brandon-T Brandon-T added this to the 1.52 milestone May 31, 2023
@Brandon-T Brandon-T self-assigned this May 31, 2023
@Brandon-T Brandon-T changed the title Fix #: Enable Highest Quality Youtube Videos Fix #7055: Enable Highest Quality Youtube Videos May 31, 2023
@Brandon-T Brandon-T marked this pull request as ready for review May 31, 2023 20:36
@Brandon-T Brandon-T requested a review from a team as a code owner May 31, 2023 20:36
@iccub iccub removed this from the 1.52 milestone Jun 1, 2023
@Brandon-T Brandon-T force-pushed the bugfix/YoutubeQuality branch from bafc2e7 to ab27d2d Compare June 12, 2023 16:02
@iccub iccub added this to the 1.53 milestone Jun 12, 2023
@Brandon-T Brandon-T force-pushed the bugfix/YoutubeQuality branch from ab27d2d to 0c12823 Compare June 12, 2023 17:57
@Brandon-T Brandon-T force-pushed the bugfix/YoutubeQuality branch from 0c12823 to 2cc0c9a Compare June 12, 2023 17:59
@iccub iccub merged commit cde94aa into development Jun 12, 2023
@iccub iccub deleted the bugfix/YoutubeQuality branch June 12, 2023 18:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Auto-upgrade of Youtube video resolution
2 participants