Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Adblock/Cosmetic filters crash #6254

Closed
iccub opened this issue Oct 26, 2022 · 6 comments · Fixed by brave/brave-core#17150, #6936 or #7148
Closed

Adblock/Cosmetic filters crash #6254

iccub opened this issue Oct 26, 2022 · 6 comments · Fixed by brave/brave-core#17150, #6936 or #7148
Assignees
@cuba
Labels
bug crash feature/shields/adblock QA Pass - iPad QA Pass - iPhone X QA Pass - iPhone QA/Yes regression release-notes/include
Milestone
1.50

Comments

@iccub
Copy link
Contributor

iccub commented Oct 26, 2022

Description:

Steps to Reproduce

No way to reproduce found so far.

Actual result:
Crash

Expected result:

Reproduces how often: [Easily reproduced, Intermittent Issue]

Brave Version:

Device details:

Website problems only:

  • did you check with Brave Shields down?
  • did you check in Safari/Firefox (WkWebView-based browsers)?

Additional Information
@iccub iccub modified the milestone: 1.44.1 Oct 26, 2022
@iccub iccub added this to the 1.48 milestone Jan 26, 2023
@iccub
Copy link
Contributor Author

iccub commented Jan 26, 2023

to retest

@iccub iccub closed this as completed Jan 26, 2023
@antonok-edm antonok-edm mentioned this issue Feb 10, 2023
Merged
25 tasks
@antonok-edm
Copy link
Collaborator

This is due to unsafe access of the adblock engine on multiple threads.

Context - https://bravesoftware.slack.com/archives/C7VLGSR55/p1676043650091859

@iccub iccub reopened this Feb 10, 2023
@iccub iccub removed this from the 1.48 milestone Feb 10, 2023
@cuba
Copy link
Contributor

cuba commented Feb 12, 2023 •
edited
Loading

My latest changes here moves all access to the engine to a serial queue: #6857. Meaning we will not be using multiple threads anymore after this change. I did performance and script injection tests and everything works well.

cuba added a commit that referenced this issue Feb 13, 2023
@cuba
Fix #6254: Fix engine crashes by using serial queue for cosmetic filters
b955af7
@cuba cuba mentioned this issue Feb 13, 2023
Merged
11 tasks
cuba added a commit that referenced this issue Feb 13, 2023
@cuba
Fix #6254: Fix engine crashes by using serial queue for cosmetic filters
480a626
cuba added a commit that referenced this issue Feb 14, 2023
@cuba
Fix #6254: Fix engine crashes by using serial queue for cosmetic filters
0640797
@kylehickinson kylehickinson reopened this Feb 14, 2023
cuba added a commit that referenced this issue Feb 16, 2023
@cuba
Fix #6254: Fix engine crashes by using serial queue for cosmetic filters
f5415c9
This was referenced Feb 16, 2023
Merged
Merged
cuba added a commit that referenced this issue Feb 20, 2023
@cuba
Fix #6254: Fix engine crashes by using serial queue for cosmetic filters
4a48c73
@kjozwiak kjozwiak added this to the 1.48 milestone Feb 21, 2023
@kjozwiak
Copy link
Member

@iccub @kylehickinson moved this into 1.48 as brave/brave-core#17283 was uplifted into 1.48. Once we get new TF builds with the above changes, we can close this off. CCing @Uni-verse please keep an eye on performance in general when using the next RC with the above and when running through the above verification.

cuba added a commit that referenced this issue Feb 22, 2023
@cuba
Fix #6254: Fix engine crashes by using serial queue for cosmetic filters
8064c4e
cuba added a commit that referenced this issue Feb 22, 2023
@cuba
Fix #6254: Fix engine crashes by using serial queue for cosmetic filters
cb23490
cuba added a commit that referenced this issue Feb 27, 2023
@cuba
Fix #6254: Fix engine crashes by using serial queue for cosmetic filters
2708e1f
cuba added a commit that referenced this issue Feb 28, 2023
@cuba
Fix #6254: Fix engine crashes by using serial queue for cosmetic filters
e44fd94
cuba added a commit that referenced this issue Mar 3, 2023
@cuba
Fix #6254: Fix engine crashes by using serial queue for cosmetic filters
c1f350e
cuba added a commit that referenced this issue Mar 3, 2023
@cuba
Fix #6254: Fix engine crashes by using serial queue for cosmetic filters
a34254c
cuba added a commit that referenced this issue Mar 7, 2023
@cuba
Fix #6254: Fix engine crashes by using serial queue for cosmetic filters
6d9ace7
cuba added a commit that referenced this issue Mar 14, 2023
@cuba
Fix #6254: Fix engine crashes by using serial queue for cosmetic filters
e3b2f37
cuba added a commit that referenced this issue Mar 15, 2023
@cuba
Fix #6254: Fix engine crashes by using serial queue for cosmetic filt…
ed8cc34 
…ers (#6936)
kylehickinson added a commit that referenced this issue Mar 17, 2023
@kylehickinson
Revert "Fix #6254: Fix engine crashes by using serial queue for cosme…
5e5df78 
…tic filters (#6936)"

This reverts commit ed8cc34.
iccub pushed a commit that referenced this issue Mar 20, 2023
@kylehickinson
Revert "Fix #6254: Fix engine crashes by using serial queue for cosme…
45be187 
…tic filters" (#7107)

Revert "Fix #6254: Fix engine crashes by using serial queue for cosmetic filters (#6936)"

This reverts commit ed8cc34.
cuba added a commit that referenced this issue Mar 25, 2023
@cuba
Fix #6254: Use serial queue for cosmetic filters
2270aab
@cuba cuba reopened this Mar 25, 2023
@cuba
Copy link
Contributor

cuba commented Mar 25, 2023

Re-opened because it was reverted

@cuba cuba mentioned this issue Mar 25, 2023
Merged
11 tasks
cuba added a commit that referenced this issue Mar 29, 2023
@cuba
Fix #6254: Use serial queue for cosmetic filters
b4c54d1
iccub pushed a commit that referenced this issue Mar 31, 2023
@cuba @iccub
Fix #6254: Use serial queue for cosmetic filters
5d785ab
@iccub iccub modified the milestones: 1.48, 1.50 Mar 31, 2023
cuba added a commit that referenced this issue Mar 31, 2023
@cuba
Fix #6254: Use serial queue for cosmetic filters
2356384
iccub added a commit that referenced this issue Apr 1, 2023
@cuba @iccub
Fix #6254: Get cosmetic filters on serial queue (#7148)
9d19802 
Co-authored-by: Michał Buczek <[email protected]>
Brandon-T pushed a commit that referenced this issue Apr 11, 2023
@cuba @iccub @Brandon-T
Fix #6254: Get cosmetic filters on serial queue (#7148)
12610a3 
Co-authored-by: Michał Buczek <[email protected]>
@Uni-verse Uni-verse mentioned this issue May 5, 2023
Closed
arthuredelstein pushed a commit to brave/brave-core that referenced this issue Feb 13, 2024
@cuba
Fix brave/brave-ios#6254: Fix engine crashes by using serial queue fo…
79d6f28 
…r cosmetic filters (brave/brave-ios#6936)
arthuredelstein pushed a commit to brave/brave-core that referenced this issue Feb 13, 2024
@kylehickinson
Revert "Fix brave/brave-ios#6254: Fix engine crashes by using serial …
014359c 
…queue for cosmetic filters" (brave/brave-ios#7107)

Revert "Fix brave/brave-ios#6254: Fix engine crashes by using serial queue for cosmetic filters (brave/brave-ios#6936)"

This reverts commit ed8cc34.
arthuredelstein pushed a commit to brave/brave-core that referenced this issue Feb 13, 2024
@cuba @iccub
Fix brave/brave-ios#6254: Get cosmetic filters on serial queue (brave…
f8763e0 
…/brave-ios#7148)

Co-authored-by: Michał Buczek <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@cuba cuba

Labels
bug crash feature/shields/adblock QA Pass - iPad QA Pass - iPhone X QA Pass - iPhone QA/Yes regression release-notes/include
Projects
None yet
Milestone
1.50
6 participants
@kylehickinson @cuba @kjozwiak @iccub @Uni-verse @antonok-edm