Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Revert "Fix #6254: Fix engine crashes by using serial queue for cosmetic filters" #7107

Merged
merged 1 commit into from
Mar 20, 2023

Conversation

kylehickinson
Copy link
Collaborator

This reverts commit ed8cc34.

Summary of Changes

This pull request reverts #6936 due to performance concerns on page loads

Submitter Checklist:

  • Unit Tests are updated to cover new or changed functionality
  • User-facing strings use NSLocalizableString()
  • New or updated UI has been tested across:
    • Light & dark mode
    • Different size classes (iPhone, landscape, iPad)
    • Different dynamic type sizes

Reviewer Checklist:

  • Issues include necessary QA labels:
    • QA/(Yes|No)
    • bug / enhancement
  • Necessary security reviews have taken place.
  • Adequate unit test coverage exists to prevent regressions.
  • Adequate test plan exists for QA to validate (if applicable).
  • Issue and pull request is assigned to a milestone (should happen at merge time).

@kylehickinson kylehickinson added this to the 1.49 milestone Mar 17, 2023
@kylehickinson kylehickinson requested a review from a team as a code owner March 17, 2023 20:37
@iccub iccub merged commit 45be187 into development Mar 20, 2023
@iccub iccub deleted the revert-serial-queue-adblock-change branch March 20, 2023 10:06
arthuredelstein pushed a commit to brave/brave-core that referenced this pull request Feb 13, 2024
…queue for cosmetic filters" (brave/brave-ios#7107)

Revert "Fix brave/brave-ios#6254: Fix engine crashes by using serial queue for cosmetic filters (brave/brave-ios#6936)"

This reverts commit ed8cc34.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants