Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Fix #6254: Fix engine crashes by using serial queue for cosmetic filters #6936

Merged
merged 6 commits into from
Mar 15, 2023
Merged

Fix #6254: Fix engine crashes by using serial queue for cosmetic filters #6936

merged 6 commits into from
Mar 15, 2023

Conversation

cuba
Copy link
Contributor

@cuba cuba commented Feb 13, 2023 •
edited
Loading

Summary of Changes

This pull request fixes #6254

Submitter Checklist:

  • Unit Tests are updated to cover new or changed functionality
  • User-facing strings use NSLocalizableString()
  • New or updated UI has been tested across:
    • Light & dark mode
    • Different size classes (iPhone, landscape, iPad)
    • Different dynamic type sizes

Test Plan:

Screenshots:

Reviewer Checklist:

  • Issues include necessary QA labels:
    • QA/(Yes|No)
    • bug / enhancement
  • Necessary security reviews have taken place.
  • Adequate unit test coverage exists to prevent regressions.
  • Adequate test plan exists for QA to validate (if applicable).
  • Issue and pull request is assigned to a milestone (should happen at merge time).

@cuba cuba requested a review from a team as a code owner February 13, 2023 19:32
@cuba cuba force-pushed the js/6254-fix-engine-crashes branch 4 times, most recently from a5e45e2 to f7a74f3 Compare February 20, 2023 12:32
@cuba cuba force-pushed the js/6254-fix-engine-crashes branch 2 times, most recently from fe95cbb to c3ddac8 Compare February 22, 2023 23:24
iccub
iccub approved these changes Feb 28, 2023
View reviewed changes
Copy link
Contributor

@iccub iccub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, lets wait for Kyle to see if theres any async await issues

@cuba cuba force-pushed the js/6254-fix-engine-crashes branch from a10df3f to 3b4f367 Compare March 3, 2023 17:37
@cuba cuba added this to the 1.49 milestone Mar 5, 2023
@iccub iccub requested a review from kylehickinson March 7, 2023 15:44
@cuba cuba force-pushed the js/6254-fix-engine-crashes branch 2 times, most recently from 3a3340f to 2ff5541 Compare March 7, 2023 18:11
@cuba cuba force-pushed the js/6254-fix-engine-crashes branch from 74b2d00 to 2e7ebd6 Compare March 14, 2023 18:22
@cuba cuba merged commit ed8cc34 into development Mar 15, 2023
@cuba cuba deleted the js/6254-fix-engine-crashes branch March 15, 2023 11:41
kylehickinson added a commit that referenced this pull request Mar 17, 2023
@kylehickinson
Revert "Fix #6254: Fix engine crashes by using serial queue for cosme…
5e5df78 
…tic filters (#6936)"

This reverts commit ed8cc34.
@kylehickinson kylehickinson mentioned this pull request Mar 17, 2023
Merged
11 tasks
iccub pushed a commit that referenced this pull request Mar 20, 2023
@kylehickinson
Revert "Fix #6254: Fix engine crashes by using serial queue for cosme…
45be187 
…tic filters" (#7107)

Revert "Fix #6254: Fix engine crashes by using serial queue for cosmetic filters (#6936)"

This reverts commit ed8cc34.
arthuredelstein pushed a commit to brave/brave-core that referenced this pull request Feb 13, 2024
@cuba
Fix brave/brave-ios#6254: Fix engine crashes by using serial queue fo…
79d6f28 
…r cosmetic filters (brave/brave-ios#6936)
arthuredelstein pushed a commit to brave/brave-core that referenced this pull request Feb 13, 2024
@kylehickinson
Revert "Fix brave/brave-ios#6254: Fix engine crashes by using serial …
014359c 
…queue for cosmetic filters" (brave/brave-ios#7107)

Revert "Fix brave/brave-ios#6254: Fix engine crashes by using serial queue for cosmetic filters (brave/brave-ios#6936)"

This reverts commit ed8cc34.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@iccub iccub iccub approved these changes

@kylehickinson kylehickinson kylehickinson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.49
Development

Successfully merging this pull request may close these issues.

Adblock/Cosmetic filters crash
3 participants
@cuba @kylehickinson @iccub