Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use thread-safe adblock-rust build config on iOS (uplift to 1.49.x) #17256

Merged
merged 1 commit into from
Feb 22, 2023
Merged

Use thread-safe adblock-rust build config on iOS (uplift to 1.49.x) #17256

merged 1 commit into from
Feb 22, 2023

Conversation

antonok-edm
Copy link
Collaborator

@antonok-edm antonok-edm commented Feb 16, 2023 •
edited by kjozwiak
Loading

Uplift of #17150
Resolves brave/brave-ios#6254

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@antonok-edm antonok-edm self-assigned this Feb 16, 2023
@antonok-edm antonok-edm requested a review from a team as a code owner February 16, 2023 18:51
@github-actions github-actions bot added the CI/run-audit-deps Check for known npm/cargo vulnerabilities (audit_deps) label Feb 16, 2023
@antonok-edm antonok-edm force-pushed the pr17150_ios-thread-safe-adblock_1.49.x branch from ae9f8fb to 8b235c2 Compare February 19, 2023 18:54
@kjozwiak kjozwiak added this to the 1.49.x - Beta milestone Feb 22, 2023
kjozwiak
kjozwiak approved these changes Feb 22, 2023
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.49.x approved 👍

@kjozwiak kjozwiak merged commit 496325e into 1.49.x Feb 22, 2023
@kjozwiak kjozwiak deleted the pr17150_ios-thread-safe-adblock_1.49.x branch February 22, 2023 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@antonok-edm antonok-edm

Labels
CI/run-audit-deps Check for known npm/cargo vulnerabilities (audit_deps)
Projects
None yet
Milestone
1.49.x - Release
Development

Successfully merging this pull request may close these issues.
2 participants
@antonok-edm @kjozwiak