Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Change first ad to appear after 2 minutes and retry after 2 minutes if no eligible ads for iOS/Android #1825

Closed
anthonypkeane opened this issue Oct 29, 2019 · 4 comments

Comments

@anthonypkeane
Copy link

anthonypkeane commented Oct 29, 2019

Description:

It takes 30 min for the first ad to be delivered. Given previous conversations, this should be 2 min.

We have also changed ads to be delivered after 2 minutes if no previous ads were eligible to be shown

Can this be fixed?

cc @jsecretan

@tmancey
Copy link
Collaborator

tmancey commented Oct 30, 2019

@anthonypkeane This has been fixed in brave/brave-browser#6661 and will be in the next build once approved

@tmancey tmancey changed the title First ad time Change first ad to appear after 2 minutes and retry after 2 minutes if no eligible ads for iOS/Android Nov 2, 2019
@kylehickinson kylehickinson added the blocked If a ticket is blocked for some reason, if not using a sub-block label, please provide info in issue label Nov 4, 2019
@kylehickinson
Copy link
Collaborator

Still waiting for brave/brave-core#3823 to be merged

@kylehickinson kylehickinson removed the blocked If a ticket is blocked for some reason, if not using a sub-block label, please provide info in issue label Nov 4, 2019
@srirambv
Copy link
Contributor

srirambv commented Nov 7, 2019

Verification passed on iPhone XR with iOS 13.2 running 1.13(19.11.6.18)

  • Clean install
    • Verified after enabling rewards and visiting a site an ad is shown after 2 mins
  • Upgrade install
    • Verified upgrading from 1.12.1 and enabling rewards and visiting a site, an ad is shown after 2 mins

Verification passed on iPhone 7+ with iOS 13.2 running 1.13(19.11.6.18)

  • Clean install
    • Verified after enabling rewards and visiting a site an ad is shown after 2 mins
  • Upgrade install
    • Verified upgrading from 1.12.1 and enabling rewards and visiting a site, an ad is shown after 2 mins

Verification passed on iPad Pro with iOS 13.2 running 1.13(19.11.6.18)

  • Clean install
    • Verified after enabling rewards and visiting a site an ad is shown after 2 mins
  • Upgrade install
    • Verified upgrading from 1.12.1 and enabling rewards and visiting a site, an ad is shown after 2 mins

@tmancey
Copy link
Collaborator

tmancey commented Nov 7, 2019

@srirambv Can we also test if there are no eligible ads that we retry after 2 mins. As only after an ad is shown should we try every x mins based upon the ads per hour. Thanks

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.