Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change first ad to appear after 2 minutes for iOS/Android #6661

Closed
tmancey opened this issue Oct 30, 2019 · 1 comment · Fixed by brave/brave-core#3823
Closed

Change first ad to appear after 2 minutes for iOS/Android #6661

tmancey opened this issue Oct 30, 2019 · 1 comment · Fixed by brave/brave-core#3823
Assignees
@tmancey
Labels
bug feature/ads OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/exclude
Milestone
1.2.x - Release

Comments

@tmancey
Copy link
Contributor

tmancey commented Oct 30, 2019 •
edited
Loading

See iOS/Android tickets for steps to reproduce and testing as this does not affect the desktop. It would be worth just making sure ads are delivered as expected on the desktop to make sure nothing regressed.

https://github.com/brave/browser-android-tabs/issues/2213
brave/brave-ios#1825
@tmancey tmancey added this to the 0.73.x - Nightly milestone Oct 30, 2019
@tmancey tmancey self-assigned this Oct 30, 2019
@tmancey tmancey added bug OS/Android Fixes related to Android browser functionality labels Oct 30, 2019
This was referenced Oct 30, 2019
Closed
Merged
@tmancey tmancey added the priority/P3 The next thing for us to work on. It'll ride the trains. label Nov 4, 2019
@LaurenWags
Copy link
Member

LaurenWags commented Nov 21, 2019 •
edited by GeetaSarvadnya
Loading

Verified passed with

Brave 1.2.7 Chromium: 78.0.3904.108 (Official Build) dev (64-bit)
Revision 4b26898a39ee037623a72fcfb77279fce0e7d648-refs/branch-heads/3904@{#889}
OS macOS Version 10.13.6 (Build 17G5019)
  • Performed basic regression test of Ads per description
  • Confirmed ads were delivered as expected per the max number of ads per hour setting
  • Confirmed view, click, landed, dismiss in confirmations.json
  • Confirmed able to redeem tokens on the server

Verified passed with

Brave 1.2.8 Chromium: 78.0.3904.108 (Official Build) dev (64-bit)
Revision 4b26898a39ee037623a72fcfb77279fce0e7d648-refs/branch-heads/3904@{#889}
OS Ubuntu 18.04 LTS

Verified the above.

Verification passed on

Brave 1.2.10 Chromium: 78.0.3904.108 (Official Build) dev (64-bit)
Revision 4b26898a39ee037623a72fcfb77279fce0e7d648-refs/branch-heads/3904@{#889}
OS Windows 10 OS Version 1803 (Build 17134.1006)
  • Performed basic regression test of Ads per description
  • Confirmed ads were delivered as expected per the max number of ads per hour setting
  • Confirmed view, click, landed, dismiss in confirmations.json
  • Confirmed able to redeem tokens on the server

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tmancey tmancey

Labels
bug feature/ads OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/exclude
Projects
None yet
Milestone
1.2.x - Release
4 participants
@tmancey @LaurenWags @btlechowski @GeetaSarvadnya