Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change first ad to appear after 2 minutes and retry after 2 minutes if no eligible ads for iOS/Android #3823

Merged
merged 1 commit into from
Nov 4, 2019

Conversation

tmancey
Copy link
Collaborator

@tmancey tmancey commented Oct 30, 2019

Fixes brave/brave-browser#6661

Submitter Checklist:

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@tmancey tmancey requested a review from masparrow October 30, 2019 11:00
@kylehickinson
Copy link
Collaborator

ping

@tmancey tmancey changed the title Change first ad to appear after 2 minutes for iOS/Android Change first ad to appear after 2 minutes and retry after 2 minutes if no eligible ads for iOS/Android Nov 2, 2019
@tmancey tmancey force-pushed the issues/6661 branch 2 times, most recently from ddc2da8 to 2341464 Compare November 2, 2019 16:18
@tmancey tmancey merged commit 4de8e57 into master Nov 4, 2019
@tmancey tmancey deleted the issues/6661 branch November 4, 2019 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change first ad to appear after 2 minutes for iOS/Android
3 participants