Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Ad "landing" confirmations are not being generated #1855

Closed
jsecretan opened this issue Oct 31, 2019 · 3 comments
Closed

Ad "landing" confirmations are not being generated #1855

jsecretan opened this issue Oct 31, 2019 · 3 comments

Comments

@jsecretan
Copy link

Description:

When an ad is clicked and you stay on the landing page for more than 10 seconds, it should generate a "landing" event confirmation to correspond to that. While I have tried this a few times, I see no landing confirmations in the database.

Steps to Reproduce

  1. Get a Brave Ad
    2.Tap the Ad
  2. Spend 15 seconds on the landing page

Actual result:
No land events in the database.

Expected result:
There should be at least some landing events in the database for the iOS platform.

Reproduces how often: [Easily reproduced, Intermittent Issue]
Easily

Brave Version:
1.13 (19.10.30.21)

Device details:
iPhone X, 13.1.3

Additional Information

@tmancey indicates that this should probably be handled by the native library automatically.

@tmancey
Copy link
Collaborator

tmancey commented Nov 5, 2019

@kylehickinson Do you call OnPageLoaded for ads, as internally we detect if an ad run through the business logic for sustaining an ad`. I expect this call is not being made.

Note: However if an ad URL is redirected (likely on staging) then sustaining of the ad will fail. You can search for Start sustaining ad interaction in in the logs to determine if working or not.

@kylehickinson
Copy link
Collaborator

@tmancey I'm pretty sure we call OnPageLoaded for ads that the user taps, yes, but I'll double check today

@tmancey
Copy link
Collaborator

tmancey commented Nov 5, 2019

@kylehickinson Great and if you could send over the console log that would be great and I will see why it could be broken. Thanks

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants