-
Notifications
You must be signed in to change notification settings - Fork 887
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes when rewards is reset ads service should shut down #6284
Conversation
c0d5b50
to
40693e7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Linux and Windows failed CI, restarting. CI failed for unrelated gn check and browser tests on other platforms |
f774ea3
to
0f89213
Compare
CI failed for unrelated |
Discussed with @NejcZdovc and instead of testing on Nightly (which is blocked by #6248), this is being tested with PR build from https://bravesoftware.slack.com/archives/C5DT3GPCH/p1596464740328400
|
Resolves brave/brave-browser#11035
Submitter Checklist:
npm run lint
)git rebase master
(if needed).git rebase -i
to squash commits (if needed).Test Plan:
Reviewer Checklist:
After-merge Checklist:
changes has landed on.