Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes storage not persist after reset (uplift to 1.12.x) #6300

Merged
merged 3 commits into from
Aug 5, 2020
Merged

Fixes storage not persist after reset (uplift to 1.12.x) #6300

merged 3 commits into from
Aug 5, 2020

Conversation

brave-builds
Copy link
Collaborator

@brave-builds brave-builds commented Jul 31, 2020 •
edited by kjozwiak
Loading

Uplift of #6285
Uplift of #6274
Uplift of #6284
Resolves brave/brave-browser#11024
Resolves brave/brave-browser#10934
Resolves brave/brave-browser#11035
Approved, please ensure that before merging:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.
  • You have tested your change on Nightly.
  • The PR milestones match the branch they are landing to.

After you merge:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@brave-builds brave-builds requested a review from NejcZdovc as a code owner July 31, 2020 19:27
@brave-builds brave-builds requested a review from a team July 31, 2020 19:27
@brave-builds brave-builds self-assigned this Jul 31, 2020
@brave-builds brave-builds added this to the 1.12.x - Release milestone Jul 31, 2020
@NejcZdovc NejcZdovc removed their request for review July 31, 2020 19:27
@NejcZdovc NejcZdovc force-pushed the pr6285_reset-reducer_1.12.x branch from 84e58a4 to 1b4e8d3 Compare August 3, 2020 09:11
@brave-builds brave-builds requested a review from tmancey as a code owner August 3, 2020 11:41
@NejcZdovc NejcZdovc removed the request for review from tmancey August 3, 2020 11:41
@tmancey tmancey mentioned this pull request Aug 3, 2020
Closed
4 tasks
@kjozwiak
Copy link
Member

kjozwiak commented Aug 4, 2020

Currently PR/Blocked due to not being able to QA #6284 until #6248 has been fixed on Nightly.

@LaurenWags
Copy link
Member

Per discussion with @NejcZdovc going to test using PR build (https://bravesoftware.slack.com/archives/C5DT3GPCH/p1596464740328400) instead of waiting for Nightly to be fixed.

kjozwiak
kjozwiak approved these changes Aug 5, 2020
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.12.x approved after deliberating with @brave/uplift-approvers. QA also verified the PRs on Nightly as per #6285 (comment), #6274 (comment) and #6284 (comment)

@kjozwiak kjozwiak merged commit f058e66 into 1.12.x Aug 5, 2020
@kjozwiak kjozwiak deleted the pr6285_reset-reducer_1.12.x branch August 5, 2020 04:54
This was referenced Aug 5, 2020
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@brave-builds brave-builds

Labels
feature/rewards
Projects
None yet
Milestone
1.12.x - Release #1
Development

Successfully merging this pull request may close these issues.
7 participants
@brave-builds @kjozwiak @LaurenWags @NejcZdovc @brave-browser-releases @emerick @tmancey