-
Notifications
You must be signed in to change notification settings - Fork 888
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes storage not persist after reset (uplift to 1.13.x) #6299
Conversation
85dc66b
to
53c5cdd
Compare
Per discussion with @NejcZdovc going to test using PR build (https://bravesoftware.slack.com/archives/C5DT3GPCH/p1596464740328400) instead of waiting for Nightly to be fixed. |
Linux failed due to known issue with Windows failed (https://ci.brave.com/job/pr-brave-browser-pr6285_reset-reducer_1.13.x/3/execution/node/755/log/) due to agent being removed and is being restarted. |
Restarting on Windows again, agent removed again. https://ci.brave.com/job/pr-brave-browser-pr6285_reset-reducer_1.13.x/4/execution/node/343/log/ |
Restarting
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Uplift into 1.13.x
approved after deliberating with @brave/uplift-approvers. QA also verified the PRs on Nightly as per #6285 (comment), #6274 (comment) and #6284 (comment)
Uplift of #6285
Uplift of #6274
Uplift of #6284
Resolves brave/brave-browser#11024
Resolves brave/brave-browser#10934
Resolves brave/brave-browser#11035
Approved, please ensure that before merging:
After you merge: