Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes Brave Ads intermittently crashes when opening a new tab - 1.12.x #6310

Merged
merged 1 commit into from
Aug 6, 2020

Conversation

tmancey
Copy link
Collaborator

@tmancey tmancey commented Aug 1, 2020

Uplift of #6304
Resolves brave/brave-browser#9393

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.
  • You have tested your change on Nightly.
  • The PR milestones match the branch they are landing to.

After you merge:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@tmancey
Copy link
Collaborator Author

tmancey commented Aug 4, 2020

CI failed for known Brave Rewards browser test issue

@kjozwiak
Copy link
Member

kjozwiak commented Aug 4, 2020

Currently PR/Blocked due to not being able to QA #6305 until #6248 has been fixed on Nightly.

@LaurenWags LaurenWags added the CI/skip-ios Do not run CI builds for iOS label Aug 4, 2020
@kjozwiak
Copy link
Member

kjozwiak commented Aug 5, 2020

Looks like it failed at the same exact spot on all the platforms other than iOS. Looks like it's failing the build process due to the following failure:

16:31:17  FAILED: obj/brave/components/brave_ads/browser/browser/ads_service_impl.o

@tmancey mind taking a look when you're around? Keeping the PR/Blocked for now till the above is resolved.

@tmancey tmancey force-pushed the issues/9393-1.12.x branch from f98e8ef to c57ba81 Compare August 5, 2020 11:55
@tmancey tmancey force-pushed the issues/9393-1.12.x branch from c57ba81 to 41cda0f Compare August 5, 2020 11:55
@tmancey
Copy link
Collaborator Author

tmancey commented Aug 5, 2020

@kjozwiak Issue resolved and builds restarted

Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.12.x approved after deliberating with @brave/uplift-approvers. QA has verified the PR on Nightly as per #6304 (comment).

@kjozwiak kjozwiak merged commit 17d0275 into 1.12.x Aug 6, 2020
@kjozwiak kjozwiak deleted the issues/9393-1.12.x branch August 6, 2020 07:48
@kjozwiak kjozwiak added this to the 1.12.x - Release milestone Aug 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug CI/skip-ios Do not run CI builds for iOS feature/ads
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants