Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace delay / polling for DOM elements with a MutationObserver #4114

Merged
merged 2 commits into from
Apr 1, 2020
Merged

Replace delay / polling for DOM elements with a MutationObserver #4114

merged 2 commits into from
Apr 1, 2020

Conversation

NejcZdovc
Copy link
Contributor

@NejcZdovc NejcZdovc commented Dec 2, 2019 •
edited
Loading

Resolves brave/brave-browser#7060

Submitter Checklist:

Test Plan:

make sure that test plans pass

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@NejcZdovc NejcZdovc added the CI/skip Do not run CI builds (except noplatform) label Dec 2, 2019
@NejcZdovc NejcZdovc self-assigned this Dec 2, 2019
@NejcZdovc NejcZdovc mentioned this pull request Dec 2, 2019
Closed
32 tasks
@NejcZdovc NejcZdovc changed the title Replace delay / polling for DOM elements with a MutationObserver. Replace delay / polling for DOM elements with a MutationObserver Dec 2, 2019
@NejcZdovc NejcZdovc added this to the 1.3.x - Nightly milestone Dec 3, 2019
@NejcZdovc NejcZdovc added feature/rewards and removed CI/skip Do not run CI builds (except noplatform) labels Dec 3, 2019
@NejcZdovc NejcZdovc requested a review from a team December 3, 2019 09:39
@NejcZdovc NejcZdovc force-pushed the tests-ovservers branch 2 times, most recently from e790dbc to 9110d04 Compare December 5, 2019 08:17
@NejcZdovc NejcZdovc modified the milestones: 1.3.x - Dev, 1.4.x - Nightly Dec 5, 2019
tmancey
tmancey approved these changes Dec 5, 2019
View reviewed changes
Copy link
Collaborator

@tmancey tmancey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM++

@NejcZdovc NejcZdovc added CI/skip-android Do not run CI builds for Android CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-windows labels Dec 6, 2019
@NejcZdovc
Copy link
Contributor Author

CI passed except on linux, so retrying linux

@NejcZdovc NejcZdovc force-pushed the tests-ovservers branch 6 times, most recently from 8688fb0 to 50f5a11 Compare December 11, 2019 15:17
@NejcZdovc NejcZdovc removed this from the 1.4.x - Nightly milestone Dec 30, 2019
@NejcZdovc NejcZdovc removed the CI/skip-macos-x64 Do not run CI builds for macOS x64 label Apr 1, 2020
@NejcZdovc NejcZdovc removed CI/skip-windows CI/skip-android Do not run CI builds for Android labels Apr 1, 2020
@NejcZdovc NejcZdovc merged commit df5da7a into master Apr 1, 2020
@NejcZdovc NejcZdovc deleted the tests-ovservers branch April 1, 2020 21:42
@NejcZdovc NejcZdovc added this to the 1.8.x - Nightly milestone Apr 1, 2020
This was referenced Apr 1, 2020
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@masparrow masparrow masparrow approved these changes

@tmancey tmancey tmancey approved these changes

Assignees

@NejcZdovc NejcZdovc

Labels
CI/skip-ios Do not run CI builds for iOS feature/rewards
Projects
None yet
Milestone
1.8.x - Release
Development

Successfully merging this pull request may close these issues.

Replace use of timed delays in browser tests to reduce flakiness
3 participants
@NejcZdovc @tmancey @masparrow