Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace use of timed delays in browser tests to reduce flakiness #7060

Closed
jhoneycutt opened this issue Nov 22, 2019 · 0 comments · Fixed by brave/brave-core#4114
Closed

Replace use of timed delays in browser tests to reduce flakiness #7060

jhoneycutt opened this issue Nov 22, 2019 · 0 comments · Fixed by brave/brave-core#4114
Assignees
@NejcZdovc
Labels
dev-concern feature/rewards QA/No release-notes/exclude
Milestone
1.8.x - Release

Comments

@jhoneycutt
Copy link

The Rewards browser tests have a number of locations where they sleep / delay for a short amount of time before running JS to test an element in the UI. The delay is meant to give the UI enough time to 'refresh' before the remainder of the test is run. This mechanism is flaky and frequently results in test failures / retries due to the UI not being in the correct state after the delay completes.

We should replace this behavior with something less flaky.
@jhoneycutt jhoneycutt mentioned this issue Nov 22, 2019
Closed
32 tasks
@NejcZdovc NejcZdovc self-assigned this Dec 2, 2019
@bbondy bbondy mentioned this issue Dec 2, 2019
Closed
7 tasks
@NejcZdovc NejcZdovc mentioned this issue Dec 2, 2019
Merged
32 tasks
NejcZdovc pushed a commit to brave/brave-core that referenced this issue Dec 3, 2019
@NejcZdovc
Replace delay / polling for DOM elements with a MutationObserver.
2b5f8ee 
Resolves brave/brave-browser#7060
@NejcZdovc NejcZdovc added this to the 1.3.x - Nightly milestone Dec 3, 2019
@NejcZdovc NejcZdovc removed this from the 1.3.x - Nightly milestone Dec 3, 2019
NejcZdovc pushed a commit to brave/brave-core that referenced this issue Dec 5, 2019
@NejcZdovc
Replace delay / polling for DOM elements with a MutationObserver.
40768bf 
Resolves brave/brave-browser#7060
@NejcZdovc NejcZdovc added this to the 1.4.x - Nightly milestone Dec 5, 2019
NejcZdovc pushed a commit to brave/brave-core that referenced this issue Dec 11, 2019
@NejcZdovc
Replace delay / polling for DOM elements with a MutationObserver.
0a0022f 
Resolves brave/brave-browser#7060
@NejcZdovc NejcZdovc removed this from the 1.4.x - Dev milestone Jan 1, 2020
NejcZdovc pushed a commit to brave/brave-core that referenced this issue Mar 6, 2020
@NejcZdovc
Replace delay / polling for DOM elements with a MutationObserver.
5944f83 
Resolves brave/brave-browser#7060
NejcZdovc pushed a commit to brave/brave-core that referenced this issue Apr 1, 2020
@NejcZdovc
Replace delay / polling for DOM elements with a MutationObserver.
ab07e63 
Resolves brave/brave-browser#7060
@kjozwiak kjozwiak mentioned this issue Apr 1, 2020
Merged
4 tasks
@NejcZdovc NejcZdovc added this to the 1.8.x - Nightly milestone Apr 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@NejcZdovc NejcZdovc

Labels
dev-concern feature/rewards QA/No release-notes/exclude
Projects
None yet
Milestone
1.8.x - Release
2 participants
@jhoneycutt @NejcZdovc