Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Replace delay / polling for DOM elements with a MutationObserver. #4059

Closed
wants to merge 1 commit into from
Closed

WIP: Replace delay / polling for DOM elements with a MutationObserver. #4059

wants to merge 1 commit into from

Conversation

jhoneycutt
Copy link

@jhoneycutt jhoneycutt commented Nov 22, 2019

Resolves brave/brave-browser#7060

Submitter Checklist:

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@NejcZdovc
Copy link
Contributor

@jhoneycutt what else needs to be done in this PR?

@NejcZdovc NejcZdovc self-assigned this Dec 2, 2019
@NejcZdovc
Copy link
Contributor

closing in favor of #4114

@NejcZdovc NejcZdovc closed this Dec 2, 2019
@NejcZdovc NejcZdovc added this to the Closed milestone Mar 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace use of timed delays in browser tests to reduce flakiness
2 participants