-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Failing browser test: BraveRewardsBrowserTest SplitProcessorAutoContribution #8956
Comments
BraveRewardsBrowserTest.SplitProcessorAutoContribution
Test was introduced with brave/brave-core#5050 - however, CI was passing at the time it was merged. Something may have changed after this which broke the test |
First PR that I see which has a failure (working backwards) is brave/brave-core#5058. Not sure if this is the cause... but the PR before that (brave/brave-core#5109) ran on macOS (which runs browser tests) and passed without issue |
@bsclifton is this something that is failing all the time? As just one PR that I did yesterday was green, so I think this is intermittent |
@NejcZdovc possibly intermittent - it has failed with the last few PRs though (started happening today). Would you be able to try on master? |
Have brave/brave-core#5129 running right now on the latest master, let's see what will happen. Trying locally as well |
This one is all green, PR created couple of hours ago brave/brave-core#5121. So for sure is intermittent |
this test passes on my machine as well, but get some other failing tests. Issue logged here #8958 |
should be fixed with brave/brave-core#4114 |
@NejcZdovc could you please take a look and let us know if this issue requires manual QA? Issue seems to be for browser tests but would like to confirm. If no manual QA needed please add |
done |
thank you! |
Description
The text was updated successfully, but these errors were encountered: