Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failing browser test: BraveRewardsBrowserTest SplitProcessorAutoContribution #8956

Closed
bsclifton opened this issue Apr 1, 2020 · 11 comments
Closed

Comments

@bsclifton
Copy link
Member

Description

20:13:31  [  FAILED  ] BraveRewardsBrowserTest.SplitProcessorAutoContribution, where TypeParam =  and GetParam() =  (8647 ms)
20:13:31  [507/507] BraveRewardsBrowserTest.SplitProcessorAutoContribution (8721 ms)
20:13:31  1 test failed:
20:13:31      BraveRewardsBrowserTest.SplitProcessorAutoContribution (../../brave/components/brave_rewards/browser/rewards_service_browsertest.cc:3111)
@bsclifton bsclifton changed the title Failing browser test: BraveRewardsBrowserTest.SplitProcessorAutoContribution Failing browser test: BraveRewardsBrowserTest SplitProcessorAutoContribution Apr 1, 2020
@bsclifton
Copy link
Member Author

Test was introduced with brave/brave-core#5050 - however, CI was passing at the time it was merged. Something may have changed after this which broke the test

@bsclifton
Copy link
Member Author

First PR that I see which has a failure (working backwards) is brave/brave-core#5058. Not sure if this is the cause... but the PR before that (brave/brave-core#5109) ran on macOS (which runs browser tests) and passed without issue

@NejcZdovc
Copy link
Contributor

@bsclifton is this something that is failing all the time? As just one PR that I did yesterday was green, so I think this is intermittent

@NejcZdovc NejcZdovc removed their assignment Apr 1, 2020
@bsclifton
Copy link
Member Author

@NejcZdovc possibly intermittent - it has failed with the last few PRs though (started happening today). Would you be able to try on master?

@NejcZdovc
Copy link
Contributor

Have brave/brave-core#5129 running right now on the latest master, let's see what will happen. Trying locally as well

@NejcZdovc
Copy link
Contributor

This one is all green, PR created couple of hours ago brave/brave-core#5121. So for sure is intermittent

@NejcZdovc
Copy link
Contributor

NejcZdovc commented Apr 1, 2020

this test passes on my machine as well, but get some other failing tests. Issue logged here #8958

@NejcZdovc
Copy link
Contributor

should be fixed with brave/brave-core#4114

@NejcZdovc NejcZdovc self-assigned this Apr 1, 2020
@NejcZdovc NejcZdovc added this to the 1.8.x - Nightly milestone Apr 1, 2020
@LaurenWags
Copy link
Member

@NejcZdovc could you please take a look and let us know if this issue requires manual QA? Issue seems to be for browser tests but would like to confirm. If no manual QA needed please add QA/No label. Thanks! cc @kjozwiak

@NejcZdovc NejcZdovc added the QA/No label Apr 9, 2020
@NejcZdovc
Copy link
Contributor

done

@LaurenWags
Copy link
Member

thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants